Skip to content

Fix CSS & JS deprecation warnings following node upgrade#1160

Merged
gabrielcld2 merged 6 commits intodevelopfrom
node-upgrade-improvements
Apr 6, 2026
Merged

Fix CSS & JS deprecation warnings following node upgrade#1160
gabrielcld2 merged 6 commits intodevelopfrom
node-upgrade-improvements

Conversation

@gabrielcld2
Copy link
Copy Markdown
Collaborator

Due to the recent node upgrade, several deprecation warnings were being shown.
These are now addressed here.

Approach

  • Replace render with createRoot
  • Migrate SCSS @import to either @use or @forward
  • Replace SCSS deprecated color functions

Note: there are two warnings left due to file sizes. These might have to remain for now:

  1. The cloudinary CSS file was already quite large. Splitting it into smaller files might be a bit more complicated.
  2. syntax-highlight.js is large due to the CodeMirror dependency. That file is thankfully only enqueued on the admin page requiring it only, so perhaps we can leave with this for now.

QA notes

  • Run npm run build to make sure assets are still building and not showing warnings (except for the two file sizes mentioned above)
  • Do some regression testing on Cloudinary settings pages, the editor, and the frontend.

Copy link
Copy Markdown

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Build is clean, all Sass warnings are gone. Tested locally and everything looks good.

@gabrielcld2 gabrielcld2 merged commit e0e1a9f into develop Apr 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants