feat(analytics): add test to detect cli

Author: strausr

packages/html/src/types.ts

@@ -24,7 +24,7 @@ export type PictureSources = {minWidth?: number, maxWidth?: number, image: Cloud
 
 export type PictureSource  = {minWidth?: number, maxWidth?: number, image: CloudinaryImage, sizes?: string};
 
-export type BaseAnalyticsOptions = {sdkSemver: string, techVersion: string, sdkCode: string, feature?: string};
+export type BaseAnalyticsOptions = {sdkSemver: string, techVersion: string, sdkCode: string, feature?: string, product?: string};
 
 export type AnalyticsOptions = Parameters<CloudinaryImage['toURL']>[0];
 

packages/html/src/utils/analytics.ts

@@ -7,6 +7,7 @@ export const getAnalyticsOptions = (options?: BaseAnalyticsOptions, features: vo
             sdkSemver: options.sdkSemver,
             techVersion: options.techVersion,
             ...(options.feature !== undefined && { feature: options.feature }),
+            ...(options.product !== undefined && { product: options.product }),
             ...features
         }
     } : null

packages/react/__tests__/analytics.test.tsx

@@ -26,3 +26,40 @@ describe('analytics', () => {
     }, 0);// one tick
   });
 });
+
+describe('analytics when created via CLI', () => {
+  let AdvancedImageCLI: typeof AdvancedImage;
+  let CloudinaryImageCLI: typeof CloudinaryImage;
+
+  beforeAll(() => {
+    process.env.CLOUDINARY_SOURCE = 'cli';
+    jest.resetModules();
+    const src = require('../src');
+    const constants = require('../src/internal/SDKAnalyticsConstants');
+    AdvancedImageCLI = src.AdvancedImage;
+    CloudinaryImageCLI = require('@cloudinary/url-gen/assets/CloudinaryImage').CloudinaryImage;
+    const SDKAnalyticsConstantsCLI = constants.SDKAnalyticsConstants;
+    SDKAnalyticsConstantsCLI.sdkSemver = '1.0.0';
+    SDKAnalyticsConstantsCLI.techVersion = '10.2.5';
+  });
+
+  afterAll(() => {
+    delete process.env.CLOUDINARY_SOURCE;
+    jest.resetModules();
+  });
+
+  it('generates analytics with Product B (Integrations) and sdkCode H (React CLI)', function (done) {
+    const cldImg = new CloudinaryImageCLI('sample', { cloudName: 'demo' });
+    const component = mount(<AdvancedImageCLI cldImg={cldImg} />);
+    setTimeout(() => {
+      const html = component.html();
+      const match = html.match(/_a=([A-Za-z0-9]+)/);
+      expect(match).toBeTruthy();
+      const token = match![1];
+      // Algorithm B: 1st = algo, 2nd = product (B = Integrations), 3rd = sdkCode (H = React CLI)
+      expect(token[1]).toBe('B');
+      expect(token[2]).toBe('H');
+      done();
+    }, 0);
+  });
+});

packages/react/src/internal/SDKAnalyticsConstants.ts

@@ -1,19 +1,19 @@
 import React from 'react'
 
-// Detect if this project was created via create-cloudinary-react CLI
-function getCLIFeatureCode(): string {
+// Detect if this project was created via create-cloudinary-react CLI (Integrations)
+function isCLI(): boolean {
   if (typeof process !== 'undefined' && process.env) {
-    if (process.env.CLOUDINARY_SOURCE === 'cli' || process.env.CLD_CLI === 'true') {
-      return 'B'; // CLI feature code
-    }
+    return process.env.CLOUDINARY_SOURCE === 'cli' || process.env.CLD_CLI === 'true';
   }
-  return '0'; // Default (no specific feature)
+  return false;
 }
 
+// When CLI: use Algorithm B with Product B (Integrations) and sdkCode H (React CLI). Otherwise React SDK: sdkCode J.
+const isCLIDetected = isCLI();
 
 export const SDKAnalyticsConstants = {
   sdkSemver: 'PACKAGE_VERSION_INJECTED_DURING_BUILD',
   techVersion: React.version,
-  sdkCode: 'J',
-  feature: getCLIFeatureCode()
+  sdkCode: isCLIDetected ? 'H' : 'J',
+  ...(isCLIDetected && { product: 'B' as const })
 };