virtio-balloon: reword a stray internal comment tag - #1462
Open
gburd wants to merge 1 commit into
Open
Conversation
The config-change polling comment carried an internal shorthand tag. Reword it as a plain TODO with the same technical content (poll because the config-change IRQ is unwired; move to the config-change vector once plumbed). No functional change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in the balloon config-change polling loop carried a stray internal shorthand tag that slipped through review. This rewords it as a plain
TODO:with the same technical content, no functional change.The note still says what it should: the loop polls because the config-change IRQ is unwired in the virtio core, and the intended follow-up is to wake on the config-change vector (VIRTIO_MSI_CONFIG_VECTOR) once that is plumbed.