CLOS-4056: replace em-dashes with ASCII for Python 2.7 / lint compat

The previous two commits introduced em-dashes (U+2014) in docstrings and
inline comments. The upstream make lint target now greps for any
non-ASCII byte (commit 92aee84) because Python 2.7 source files reject
non-ASCII without an encoding declaration, and the leapp framework still
supports running on 2.7 in places. Replace each em-dash with an ASCII
hyphen so the files lint clean against that gate.

Author: prilr

repos/system_upgrade/cloudlinux/actors/checkrhnversionoverride/actor.py

@@ -21,7 +21,7 @@ class CheckRhnVersionOverride(Actor):
     def process(self):
         if not is_cln_package_channel_active():
             # CLOS-4056: versionOverride only matters when CLN is delivering
-            # packages — the upgrade rewrites it to drive channel selection.
+            # packages - the upgrade rewrites it to drive channel selection.
             # On no-auth (SWNG) systems the package channel is cl-channel,
             # not CLN, so there is nothing to inspect or warn about even if
             # /etc/sysconfig/rhn/up2date is still present from registration.

repos/system_upgrade/cloudlinux/actors/pinclnmirror/actor.py

@@ -29,7 +29,7 @@ def process(self):
         if not is_cln_package_channel_active():
             # CLOS-4056: pinning the CLN mirror is only meaningful when CLN
             # is delivering packages. On no-auth (SWNG) systems packages come
-            # from cl-channel via mirrorlist, so there is nothing to pin —
+            # from cl-channel via mirrorlist, so there is nothing to pin -
             # registration may still be in place but is irrelevant here.
             api.current_logger().info(
                 "CLN is not the active package channel; skipping mirror pinning"

repos/system_upgrade/cloudlinux/actors/resetrhnversionoverride/actor.py

@@ -20,7 +20,7 @@ def process(self):
         if not is_cln_package_channel_active():
             # CLOS-4056: versionOverride is only set/used by the CLN package
             # channel flow. If the system isn't on CLN for packages, leave
-            # /etc/sysconfig/rhn/up2date alone — registration metadata there
+            # /etc/sysconfig/rhn/up2date alone - registration metadata there
             # is not ours to touch.
             return
 

repos/system_upgrade/cloudlinux/actors/switchclnchannel/actor.py

@@ -25,7 +25,7 @@ class SwitchClnChannel(Actor):
     def process(self):
         if not is_cln_package_channel_active():
             # CLOS-4056: CLN is no longer the package channel here (no-auth /
-            # SWNG mode). Skipping the channel switch is correct — packages
+            # SWNG mode). Skipping the channel switch is correct - packages
             # come from cl-channel / cloudlinux9-baseos instead. The system
             # may still be CLN-registered for licensing; that is a separate
             # concern this actor does not need to manage.
@@ -40,7 +40,7 @@ def process(self):
             # CLOS-4056: Do not inhibit. Even on systems that ARE using CLN
             # as the package channel, a transient CLN-server reachability
             # problem at FirstBoot (DNS/network not up yet) shouldn't block
-            # the upgrade — the no-auth fallback repos still serve packages.
+            # the upgrade - the no-auth fallback repos still serve packages.
             reporting.create_report(
                 [
                     reporting.Title(
@@ -50,7 +50,7 @@ def process(self):
                         "Command {} failed with exit code {}."
                         " The most probable cause of that is a problem with this system's"
                         " CloudLinux Network registration. If this system now uses the"
-                        " no-auth (SWNG) repository scheme, this failure is harmless —"
+                        " no-auth (SWNG) repository scheme, this failure is harmless -"
                         " CL9 packages come from cl-channel / cloudlinux9-baseos instead"
                         " of CLN.".format(e.command, e.exit_code)
                     ),

repos/system_upgrade/cloudlinux/libraries/cln_detect.py

@@ -2,17 +2,17 @@
 
 CLN has historically combined two concerns:
 
-  1. **Registration / identity** — the system is registered with the CLN
+  1. **Registration / identity** - the system is registered with the CLN
      server (`/etc/sysconfig/rhn/systemid`, JWT token), used for licensing
      and inventory regardless of how packages are delivered.
 
-  2. **Package delivery** — the system pulls CloudLinux packages through
+  2. **Package delivery** - the system pulls CloudLinux packages through
      the spacewalk DNF/YUM plugin against the CLN-side channel
      (`cloudlinux-x86_64-server-N`).
 
 The no-auth (SWNG) transition decouples these. New CL8 and CL9 systems
 keep CLN **registration** but no longer use CLN as the **package
-channel** — packages come from the SWNG mirrorlist via
+channel** - packages come from the SWNG mirrorlist via
 `/etc/yum.repos.d/cl.repo` (`cl-channel`) instead. `rhn-client-tools
 >= 3.0.1` disables the spacewalk plugin to enforce this.
 
@@ -57,7 +57,7 @@ def is_cln_package_channel_active():
     so CLN-targeting actions (channel switch, mirror pinning, version
     overrides) are not meaningful and should be skipped.
 
-    This is a deliberately heuristic check — it asks "is CLN going to
+    This is a deliberately heuristic check - it asks "is CLN going to
     serve packages here", not "is the system registered with CLN" (the
     two were the same thing pre-no-auth and have since diverged).
     """