CLOS-3716: inhibit elevate when target kernel minor outruns userland#66
Open
prilr wants to merge 1 commit into
Open
Conversation
Defense-in-depth Checks-phase actor that compares the newest available `kernel-core` minor against the newest available `cloudlinux-release` minor in the target userspace's repositories. When the kernel minor is higher (the gradual-rollout-leak shape behind ZD 268790), an INHIBITOR report stops the upgrade with a remediation pointing at re-running once the rollout has finished promoting the rest of the userland. The customer's CL8->CL9 elevate landed during the staged 9.7 rollout: the CLN package channel `cloudlinux-x86_64-server-9` (the bare-major channel `cln_switch` switches to) was already serving the 9.7 kernel for this system's rollout slot while still serving 9.6 cloudlinux-release/kmod-lve. `dnf` installed both kernels; `scaninstalledtargetkernelversion` + `forcedefaultboottotargetkernelversion` then set default boot to the newer (611.el9_7) kernel, which kmod-lve-2.1-52.el9 (built for el9_6) couldn't load -> kmodlve missing -> LVE broken. The actor consumes `TargetUserSpaceInfo` and runs `dnf repoquery --installroot=...` against the target container. Because the container's repoquery returns the union of source+target repos (empirically validated on a CL8.10 nopanel target: `cloudlinux-release-8.10` rows surface alongside the 9.x set), the parsers filter both kernel dist-tags (`elN_M`) and `cloudlinux-release` versions (`N.M`) by the target major before taking the max. The same actor protects el7->el8 and el8->el9 - the regex is parametric on the target major. Phase: `TargetTransactionChecksPhaseTag` (same phase as `missinggpgkeysinhibitor`). `TargetUserSpaceInfo` is produced by `target_userspace_creator` at `TargetTransactionFactsPhaseTag`, so an earlier ChecksPhase actor wouldn't have a target userspace to query. Validation: - Unit tests cover parsing (vendor-suffix, no-minor-tag, cross-major rejection) and `process()` (match, leak, release-ahead, missing data, el8_10 path, cross-major rows in target userspace). - Live CL8.10 nopanel VM (Flow C, template 27486): `leapp preupgrade` reaches the actor, repoqueries the target container, reports `kernel-core minor=el9_8, cloudlinux-release minor=9.8` (current target repo state, matched -> no inhibitor). Phase + container query + major filter all confirmed end-to-end. The exact mismatch branch is unit-test only - the 9.7 rollout window the customer hit is closed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
azheregelya
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defense-in-depth Checks-phase actor that compares the newest available
kernel-coreminor against the newest availablecloudlinux-releaseminor in the target userspace's repositories. When the kernel minor is higher (the gradual-rollout-leak shape behind ZD 268790), an INHIBITOR report stops the upgrade with a remediation pointing at re-running once the rollout has finished promoting the rest of the userland.The customer's CL8->CL9 upgrade landed during the 9.7 rollout: the CLN package channel
cloudlinux-x86_64-server-9(the bare-major channelcln_switchswitches to) was already serving the 9.7 kernel for this system's rollout slot while still serving 9.6 cloudlinux-release/kmod-lve.dnfinstalled both kernels; then set default boot to the newer (611.el9_7) kernel, which kmod-lve-2.1-52.el9 (built for el9_6) couldn't load -> kmodlve missing -> LVE broken.The actor consumes
TargetUserSpaceInfoand runsdnf repoquery --installroot=...against the target container.Because the container's repoquery returns the union of source+target repos, the parsers filter both kernel dist-tags (
elN_M) andcloudlinux-releaseversions (N.M) by the target major before taking the max. The same actor protects el7->el8 and el8->el9 - the regex is parametric on the target major.Phase:
TargetTransactionChecksPhaseTag(same phase asmissinggpgkeysinhibitor).TargetUserSpaceInfois produced bytarget_userspace_creatoratTargetTransactionFactsPhaseTag, so an earlier ChecksPhase actor wouldn't have a target userspace to query.Validation:
process()(match, leak, release-ahead, missing data, el8_10 path, cross-major rows in target userspace).leapp preupgradereaches the actor, repoqueries the target container, reportskernel-core minor=el9_8, cloudlinux-release minor=9.8(current target repo state, matched -> no inhibitor). The exact mismatch branch is unit-test only - the 9.7 rollout window the customer hit is closed.