Skip to content

allow certificate isssuer to be optional, wire issuerName #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
North14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow certificate isssuer to be optional, wire issuerName #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/plugin-barman-cloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Helm Chart for CloudNativePG's CNPG-I backup plugin using Barman Cloud
| affinity | object | `{}` | Affinity for the operator to be installed. |
| certificate.createClientCertificate | bool | `true` | Specifies whether the client certificate should be created. |
| certificate.createServerCertificate | bool | `true` | Specifies whether the server certificate should be created. |
| certificate.createIssuer | bool | `true` | Specifies whether the issuer object should be created. |
| certificate.duration | string | `"2160h"` | The duration of the certificates. |
| certificate.issuerName | string | `"selfsigned-issuer"` | The name of the issuer to use for the certificates. |
| certificate.renewBefore | string | `"360h"` | The renew before time for the certificates. |
Expand Down
4 changes: 3 additions & 1 deletion charts/plugin-barman-cloud/templates/certificate-issuer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
#
# SPDX-License-Identifier: Apache-2.0
#
{{- if .Values.certificate.createIssuer }}
---
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-{{ .Values.certificate.issuerName }}
namespace: {{ include "plugin-barman-cloud.namespace" . }}
spec:
selfSigned: {}
{{- end }}
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/templates/client-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
issuerRef:
group: cert-manager.io
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-{{ .Values.certificate.issuerName }}
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
secretName: barman-cloud-client-tls
usages:
Expand Down
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/templates/server-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
issuerRef:
group: cert-manager.io
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-{{ .Values.certificate.issuerName }}
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
secretName: barman-cloud-server-tls
usages:
Expand Down
8 changes: 8 additions & 0 deletions charts/plugin-barman-cloud/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@
"title": "createServerCertificate",
"type": "boolean"
},
"createIssuer": {
"default": true,
"description": "Specifies whether the issuer object should be created.",
"required": [],
"title": "createIssuer",
"type": "boolean"
},
"duration": {
"default": "2160h",
"description": "The duration of the certificates.",
Expand All @@ -66,6 +73,7 @@
"required": [
"createClientCertificate",
"createServerCertificate",
"createIssuer",
"issuerName",
"duration",
"renewBefore"
Expand Down
2 changes: 2 additions & 0 deletions charts/plugin-barman-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ certificate:
createClientCertificate: true
# -- Specifies whether the server certificate should be created.
createServerCertificate: true
# -- Specifies whether the issuer should be created.
createIssuer: true
# -- The name of the issuer to use for the certificates.
issuerName: selfsigned-issuer
# -- The duration of the certificates.
Expand Down