feat(alerting): allow extra labels on PrometheusRules alerts#859
Open
MagicRR wants to merge 1 commit into
Open
feat(alerting): allow extra labels on PrometheusRules alerts#859MagicRR wants to merge 1 commit into
MagicRR wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:XS
Author
|
Hello @itay-grudev, thank you for the review. |
Contributor
|
Hello @MagicRR , I have the same need than you for extra-labels. May you fix the conflicts please ? |
Contributor
|
My 2 cents for the var naming, as we have already "additionalLabels" var naming for subLabelling, maybe keeping consistency there renaming |
MagicRR
requested review from
fcanovai,
gbartolini,
leonardoce,
mnencia and
phisco
as code owners
Author
|
Sounds good to me, I'll make the changes |
MagicRR
force-pushed
the
feat-858
branch
2 times, most recently
from
0192cf7 to
74f9de7
Compare
Contributor
|
@MagicRR, thanks for the changes. Can you enhance the monitoring test and verify that one prometheusRule in the ones generated have the additionnal label included ? |
Contributor
Contributor
Signed-off-by: MagicRR <r.richard.94@orange.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This feature allows declaring extra labels on PrometheusRule alerts generated by the chart when enabling the monitoring.
Linked to issue : #858