feat(plugin-barman-cloud): make the ClusterRole's CNPG API group configurable#945
Open
mnencia wants to merge 1 commit into
Open
feat(plugin-barman-cloud): make the ClusterRole's CNPG API group configurable#945mnencia wants to merge 1 commit into
mnencia wants to merge 1 commit into
Conversation
mnencia
requested review from
fcanovai,
gbartolini,
itay-grudev and
leonardoce
as code owners
dosubot
Bot
added
the
size:XS
The ClusterRole grants get/list/watch on backups and update on clusters/finalizers only in the postgresql.cnpg.io API group. Any CloudNativePG-based operator whose Cluster CRD lives under a different API group can never satisfy Kubernetes' OwnerReferencesPermissionEnforcement admission check when the plugin creates its per-Cluster Role/RoleBinding with blockOwnerDeletion: true, so reconciliation gets stuck permanently for every plugin-backed Cluster. Add rbac.cnpgGroup (default postgresql.cnpg.io) and template both rules with it, so operators built on a renamed CRD group can install this chart with one value set instead of hand-patching the ClusterRole after install. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/plugin-barman-cloud-rbac-group
branch
from
1705c40 to
c9e398f
Compare
mnencia
changed the title
itay-grudev
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClusterRole grants get/list/watch on backups and update on clusters/finalizers only in the postgresql.cnpg.io API group. Any CloudNativePG-based operator whose Cluster CRD lives under a different API group can never satisfy Kubernetes' OwnerReferencesPermissionEnforcement admission check when the plugin creates its per-Cluster Role/RoleBinding with blockOwnerDeletion: true, so reconciliation gets stuck permanently for every plugin-backed Cluster.
Add rbac.cnpgGroup (default postgresql.cnpg.io) and template both rules with it, so operators built on a renamed CRD group can install this chart with one value set instead of hand-patching the ClusterRole after install.