Make reconcile error panels honor Grafana time range#63
Open
swills wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the cluster dashboard reconcile error panels so they honor the Grafana-selected time range instead of using raw cumulative counters.
This closes #62 and is related to #48
The dashboard currently uses raw
controller_runtime_reconcile_total{result="error"}counters for several reconcile error panels. Examples:and:
Since controller_runtime_reconcile_total is a monotonically increasing counter, these queries effectively answer:
"Has this controller ever seen a reconcile error since the metrics process started?" This makes the panels stay red/noisy long after transient issues have cleared.
This PR wraps those counters with
increase(...[$__range]). For example:and:
Using increase(...[$__range]) makes the panel reflect reconcile errors that occurred within the currently selected Grafana time range. That means the panel semantics become:
"Did any reconcile errors occur during the selected dashboard time range?"
instead of:
"Did any reconcile errors ever occur since the operator process started?"
This works well for interactive dashboard use because it naturally follows the Grafana time picker:
This PR updates: