chore: enable OCI artifact type for attestation manifests#95
Open
gbartolini wants to merge 1 commit intomainfrom
Open
chore: enable OCI artifact type for attestation manifests#95gbartolini wants to merge 1 commit intomainfrom
gbartolini wants to merge 1 commit intomainfrom
Conversation
BuildKit's default image exporter does not set `artifactType` or the OCI 1.1 Referrers `subject` backlink on attestation manifests. Setting `oci-artifact=true` on the image exporter adds both, so SBOM and provenance attestations become discoverable through the OCI Referrers API. `oci-mediatypes=true` is redundant (BuildKit already defaults it to true when pushing to a registry, which is why the top-level index is already `application/vnd.oci.image.index.v1+json`) but kept for clarity. Same fix as cloudnative-pg/cloudnative-pg#10601, mirroring cloudnative-pg/postgres-extensions-containers#198. Closes #94 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
gbartolini
requested review from
NiccoloFei,
fcanovai,
jbattiato,
litaocdl,
mnencia and
sxd
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildKit's default image exporter does not set
artifactTypeor the OCI 1.1 Referrerssubjectbacklink on attestation manifests. Settingoci-artifact=trueon the image exporter adds both, so SBOM and provenance attestations become discoverable through the OCI Referrers API.oci-mediatypes=trueis redundant (BuildKit already defaults it to true when pushing to a registry, which is why the top-level index is alreadyapplication/vnd.oci.image.index.v1+json) but kept for clarity.Same fix as cloudnative-pg/cloudnative-pg#10601, mirroring cloudnative-pg/postgres-extensions-containers#198.
Closes #94