Skip to content

Commit 3efe655

Browse files
authored
ci: stop Dagger from shallow-cloning the working tree (#947)
In GitHub Actions pull request builds, Dagger's telemetry git-label collection runs `git fetch --depth 1` against the working tree whenever GITHUB_REF is a refs/pull/ ref, which turns the checkout into a shallow clone. Once shallow, `git merge-base origin/main HEAD` finds no common ancestor and the commitlint task (--from=origin/main) fails on every pull request. Most dagger invocations already prefix GITHUB_REF= to suppress this; a few were missing it. Prefix the remaining calls so Dagger never shallow-fetches the host repository. Upstream Dagger bug: dagger/dagger#13351 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
1 parent fd333cb commit 3efe655

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

Taskfile.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ tasks:
122122
docusaurus-version-is-aligned:
123123
desc: Verify that a documentation version exists for the current version of the plugin
124124
cmds:
125-
- $(dagger -s call -m dagger/check-doc-version has-version-documentation --src .)
125+
- $(GITHUB_REF= dagger -s call -m dagger/check-doc-version has-version-documentation --src .)
126126
src:
127127
- .release-please-manifest.json
128128
- ./web/versions.json
@@ -366,12 +366,12 @@ tasks:
366366
DAGGER_DOCKER_SHA: ee12c1a4a2630e194ec20c5a9959183e3a78c192
367367
cmds:
368368
- >
369-
dagger call -m github.com/purpleclay/daggerverse/docker@${DAGGER_DOCKER_SHA}
369+
GITHUB_REF= dagger call -m github.com/purpleclay/daggerverse/docker@${DAGGER_DOCKER_SHA}
370370
--registry ghcr.io --username $REGISTRY_USER --password env:REGISTRY_PASSWORD
371371
build --dir . --file containers/Dockerfile.plugin --args GO_VERSION={{.GO_VERSION}} --platform linux/amd64 --platform linux/arm64
372372
publish --ref {{.PLUGIN_IMAGE_NAME}} --tags {{.IMAGE_VERSION}}
373373
- >
374-
dagger call -m github.com/purpleclay/daggerverse/docker@${DAGGER_DOCKER_SHA}
374+
GITHUB_REF= dagger call -m github.com/purpleclay/daggerverse/docker@${DAGGER_DOCKER_SHA}
375375
--registry ghcr.io --username $REGISTRY_USER --password env:REGISTRY_PASSWORD
376376
build --dir . --file containers/Dockerfile.sidecar --args GO_VERSION={{.GO_VERSION}} --platform linux/amd64 --platform linux/arm64
377377
publish --ref {{.SIDECAR_IMAGE_NAME}} --tags {{.IMAGE_VERSION}}
@@ -456,13 +456,13 @@ tasks:
456456
DAGGER_KUSTOMIZE_SHA: ff27cd50f6b4eed2e3753c520632cd6099e1ce52
457457
cmds:
458458
- >
459-
dagger -s call -m https://github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA}
459+
GITHUB_REF= dagger -s call -m https://github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA}
460460
edit --source . --dir kubernetes
461461
set image --image plugin-barman-cloud={{.PLUGIN_IMAGE_NAME}}:{{.IMAGE_VERSION}}
462462
set secret --secret plugin-barman-cloud --from-literal SIDECAR_IMAGE={{.SIDECAR_IMAGE_NAME}}:{{.IMAGE_VERSION}}
463463
directory directory --path kubernetes export --path manifest-build
464464
- >
465-
dagger -s call -m github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA}
465+
GITHUB_REF= dagger -s call -m github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA}
466466
build --source . --dir manifest-build export --path manifest.yaml
467467
sources:
468468
- ./config/**/*.yaml
@@ -489,7 +489,7 @@ tasks:
489489
msg: not a tag, failing
490490
cmds:
491491
- >
492-
dagger -s call -m github.com/sagikazarmark/daggerverse/gh@${DAGGER_GH_SHA}
492+
GITHUB_REF= dagger -s call -m github.com/sagikazarmark/daggerverse/gh@${DAGGER_GH_SHA}
493493
with-source --source .
494494
run --repo {{.GITHUB_REPOSITORY}} --token env:GITHUB_TOKEN
495495
--cmd "release upload {{.GITHUB_REF_NAME}} manifest.yaml"

0 commit comments

Comments
 (0)