Skip to content

Commit 4a94cb9

Browse files
authored
fix(metrics): announce sidecar injection capability (#776)
The operator was not announcing the TYPE_INSTANCE_SIDECAR_INJECTION capability so the CNPG operator did not consider the plugin enabled for instance pods. The instance manager never queried the plugin's metrics endpoint, and the barman_cloud_cloudnative_pg_io_* metrics were missing entirely. This bug was masked when isWALArchiver was set to true in the plugin configuration, because the backward compatibility code in CNPG would mark the plugin as enabled as a side-effect. Users with isWALArchiver set to false (or omitted) never saw the new metrics. Closes #682 Signed-off-by: Kenny Root <kenny@the-b.org>
1 parent 376e178 commit 4a94cb9

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

internal/cnpgi/operator/identity.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,13 @@ func (i IdentityImplementation) GetPluginCapabilities(
6262
},
6363
},
6464
},
65+
{
66+
Type: &identity.PluginCapability_Service_{
67+
Service: &identity.PluginCapability_Service{
68+
Type: identity.PluginCapability_Service_TYPE_INSTANCE_SIDECAR_INJECTION,
69+
},
70+
},
71+
},
6572
},
6673
}, nil
6774
}

0 commit comments

Comments
 (0)