Skip to content

Commit 1854c71

Browse files
authored
fix: target arg in generate-testing-values (#130)
Changing the type of the `GenerateTestingValue()` `target` argument from `Directory` to `String`. This way the target is interpreted as relative to the source. Closes #129 Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
1 parent 8fc5417 commit 1854c71

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

dagger/maintenance/main.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ func (m *Maintenance) GenerateTestingValues(
142142
// +ignore=["dagger", ".github"]
143143
// +defaultPath="/"
144144
source *dagger.Directory,
145-
// Path to the target extension directory
146-
target *dagger.Directory,
145+
// The target extension to generate values for
146+
target string,
147147
// URL reference to the extension image to test [REPOSITORY[:TAG]]
148148
// +optional
149149
extensionImage string,
@@ -154,7 +154,7 @@ func (m *Maintenance) GenerateTestingValues(
154154
// +optional
155155
registryPassword *dagger.Secret,
156156
) (*dagger.File, error) {
157-
metadata, err := parseExtensionMetadata(ctx, target)
157+
metadata, err := parseExtensionMetadata(ctx, source.Directory(target))
158158
if err != nil {
159159
return nil, err
160160
}
@@ -216,9 +216,9 @@ func (m *Maintenance) GenerateTestingValues(
216216
return nil, err
217217
}
218218

219-
result := target.WithNewFile("values.yaml", string(valuesYaml))
219+
result := dag.File("values.yaml", string(valuesYaml))
220220

221-
return result.File("values.yaml"), nil
221+
return result, nil
222222
}
223223

224224
// Scaffolds a new Postgres extension directory structure

0 commit comments

Comments
 (0)