chore: review (#95)

Signed-off-by: Matteo <matteo.biagetti@enterprisedb.com>

Author: mbiagetti

dagger/maintenance/image.go

@@ -103,7 +103,7 @@ func getExtensionImageWithTimestamp(metadata *extensionMetadata, distribution st
 	}
 	if latestTag == "" {
 		return "", fmt.Errorf(
-			"no image found for image %s (version=%s pgMajor=%d os=%s",
+			"no image found for image %s (version=%s pgMajor=%d os=%s)",
 			imageName, version, pgMajor, distribution,
 		)
 	}

dagger/maintenance/main.go

@@ -455,17 +455,17 @@ func (m *Maintenance) GenerateCatalogs(
 				continue
 			}
 
+			metadata, err := parseExtensionMetadata(ctx, source.Directory(dir))
+			if err != nil {
+				return nil, fmt.Errorf("while parsing extension %s metadata: %w", extension, err)
+			}
+
 			for i := range catalog.Spec.Images {
 				img := &catalog.Spec.Images[i]
 				if !slices.Contains(matrix.MajorVersions, strconv.Itoa(img.Major)) {
 					continue
 				}
 
-				metadata, err := parseExtensionMetadata(ctx, source.Directory(dir))
-				if err != nil {
-					return nil, fmt.Errorf("while parsing extension %s metadata: %w", extension, err)
-				}
-
 				targetExtensionImage, err := getExtensionImageWithTimestamp(metadata, catalogOS, img.Major)
 				if err != nil {
 					return nil, fmt.Errorf("while retrieving extension %s image: %w", extension, err)