feat: use timestamped tags

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>

Author: NiccoloFei

dagger/maintenance/image.go

@@ -6,6 +6,7 @@ import (
 	"regexp"
 	"strconv"
 
+	"github.com/google/go-containerregistry/pkg/crane"
 	"github.com/google/go-containerregistry/pkg/name"
 	containerregistryv1 "github.com/google/go-containerregistry/pkg/v1"
 	"github.com/google/go-containerregistry/pkg/v1/remote"
@@ -59,10 +60,61 @@ func getDefaultExtensionImage(metadata *extensionMetadata) (string, error) {
 	return getExtensionImage(metadata, DefaultDistribution, DefaultPgMajor)
 }
 
-// getExtensionImage returns the extension image for a given distribution and pgMajor,
-// resolved from the metadata.
+// getExtensionImage returns the extension image for a given distribution and pgMajor.
 func getExtensionImage(metadata *extensionMetadata, distribution string, pgMajor int) (string, error) {
-	packageVersion := metadata.Versions[distribution][strconv.Itoa(pgMajor)]
+	version, err := extractExtensionVersion(metadata.Versions, distribution, pgMajor)
+	if err != nil {
+		return "", fmt.Errorf("while extracting extension version for %s: %w", metadata.Name, err)
+	}
+
+	image := fmt.Sprintf("ghcr.io/cloudnative-pg/%s:%s-%d-%s",
+		metadata.ImageName, version, pgMajor, distribution)
+
+	return image, nil
+}
+
+// getExtensionImageWithTimestamp returns the extension image with the latest timestamp
+// for a given distribution and pgMajor.
+func getExtensionImageWithTimestamp(metadata *extensionMetadata, distribution string, pgMajor int) (string, error) {
+	imageName := fmt.Sprintf("ghcr.io/cloudnative-pg/%s", metadata.ImageName)
+	tags, err := crane.ListTags(imageName)
+	if err != nil {
+		return "", fmt.Errorf("while listing tags for image %s: %w", imageName, err)
+	}
+
+	version, err := extractExtensionVersion(metadata.Versions, distribution, pgMajor)
+	if err != nil {
+		return "", fmt.Errorf("while extracting extension version for %s: %w", metadata.Name, err)
+	}
+
+	re := regexp.MustCompile(
+		fmt.Sprintf(`^%s-(\d{12})-%d-%s$`,
+			regexp.QuoteMeta(version),
+			pgMajor,
+			distribution,
+		),
+	)
+
+	var latestTag string
+	for _, tag := range tags {
+		if re.MatchString(tag) && tag > latestTag {
+			latestTag = tag
+		}
+	}
+	if latestTag == "" {
+		return "", fmt.Errorf(
+			"no image found for image %s (version=%s pgMajor=%d os=%s",
+			imageName, version, pgMajor, distribution,
+		)
+	}
+
+	return fmt.Sprintf("%s:%s", imageName, latestTag), nil
+}
+
+// extractExtensionVersion returns the extension version for a given distribution and pgMajor,
+// extracted from the extension's metadata.
+func extractExtensionVersion(versions versionMap, distribution string, pgMajor int) (string, error) {
+	packageVersion := versions[distribution][strconv.Itoa(pgMajor)]
 	if packageVersion == "" {
 		return "", fmt.Errorf("no package version found for distribution %q and version %d",
 			distribution, pgMajor)
@@ -73,9 +125,6 @@ func getExtensionImage(metadata *extensionMetadata, distribution string, pgMajor
 	if len(matches) < 2 {
 		return "", fmt.Errorf("cannot extract extension version from %q", packageVersion)
 	}
-	version := matches[1]
-	image := fmt.Sprintf("ghcr.io/cloudnative-pg/%s:%s-%d-%s",
-		metadata.ImageName, version, pgMajor, distribution)
 
-	return image, nil
+	return matches[1], nil
 }

dagger/maintenance/main.go

@@ -466,7 +466,7 @@ func (m *Maintenance) GenerateCatalogs(
 					return nil, fmt.Errorf("while parsing extension %s metadata: %w", extension, err)
 				}
 
-				targetExtensionImage, err := getExtensionImage(metadata, catalogOS, img.Major)
+				targetExtensionImage, err := getExtensionImageWithTimestamp(metadata, catalogOS, img.Major)
 				if err != nil {
 					return nil, fmt.Errorf("while retrieving extension %s image: %w", extension, err)
 				}