#345 Fix registration of CES password-management service (regression of #163)#346
Closed
henry-bobka wants to merge 3 commits into
Closed
#345 Fix registration of CES password-management service (regression of #163)#346henry-bobka wants to merge 3 commits into
henry-bobka wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the CAS 6 => 7 / Spring Boot 2 => 3 upgrade, no mails were sent for CAS-driven flows but the UI reported "Password Reset Instructions Sent Successfully" — so the failure was invisible.
The drop was address-dependent and on the application layer:
admin@ces.local=> CAS logsEmail address [admin@ces.local] for [admin] is not validand sends nothing.admin@example.com=> mail flows normally.This is a regression of #163:
CesLdapPasswordManagementService(which deliberately deactivates the e-mail-address validation for internal addresses likeadmin@ces.local) was no longer the activepasswordChangeServiceat runtime.The config class gated the CES override on
@ConditionalOnProperty(name = "cas.authn.pm.ldap[0].ldap-url"). Indexed[0]property names are no longer resolved reliably by@ConditionalOnPropertysince Spring Boot 3, so the condition silently stopped matching — the CES bean was never registered and the stock ApereopasswordChangeService(with active e-mail validation) took over.Close #345