Skip to content

Add storage_type variable pass-through to RDS cluster module#79

Closed
Benbentwo with Copilot wants to merge 1 commit into
mainfrom
copilot/update-storage-type-variable
Closed

Add storage_type variable pass-through to RDS cluster module#79
Benbentwo with Copilot wants to merge 1 commit into
mainfrom
copilot/update-storage-type-variable

Conversation

Copilot AI commented Jan 14, 2026

Copy link
Copy Markdown

Enables storage type configuration for Aurora PostgreSQL clusters by exposing the storage_type parameter from the underlying cloudposse/rds-cluster/aws module.

Changes

  • src/variables.tf: Added storage_type variable with validation for valid AWS storage types (standard, gp2, io1, aurora, aurora-iopt1)
  • src/cluster-regional.tf: Pass storage_type to the aurora_postgres_cluster module

Usage

components:
  terraform:
    aurora-postgres:
      vars:
        storage_type: aurora-iopt1  # Optional, defaults to null
        # ... other configuration

The variable accepts null (default), allowing AWS to select the appropriate storage type when not explicitly configured.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkpoint-api.hashicorp.com
    • Triggering command: /usr/local/bin/terraform terraform version (dns block)
    • Triggering command: /usr/local/bin/terraform terraform fmt -check -recursive (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Update the Terraform configuration to include the storage_type variable as a pass-through parameter from the root module to the @cloudposse/terraform-aws-rds-cluster submodule. This requires the following changes:

  1. Define a new storage_type variable in src/variables.tf, ensuring it matches the structure and description of the variable in the @cloudposse/terraform-aws-rds-cluster repository:

    variable "storage_type" {
      type        = string
      description = "One of 'standard' (magnetic), 'gp2' (general purpose SSD), 'io1' (provisioned IOPS SSD), 'aurora', or 'aurora-iopt1'"
      default     = null
    }
  2. Update src/cluster-regional.tf to pass the storage_type variable from the root module to the submodule configuration:

    storage_type = var.storage_type

These adjustments allow users to configure storage types via the root module, propagating the setting to the submodule.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai

coderabbitai Bot commented Jan 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot requested review from a team January 14, 2026 22:57
@mergify

mergify Bot commented Jan 14, 2026

Copy link
Copy Markdown

Important

Title is necessary and should not be empty.

Kindly provide a meaningful title for this Pull Request.

@mergify mergify Bot closed this Jan 14, 2026
@mergify

mergify Bot commented Jan 14, 2026

Copy link
Copy Markdown

This pull request was automatically closed as it no longer contains any changes.

This typically happens when another merged pull request has already included this request's
proposed modifications into the default branch.

@mergify mergify Bot added no-changes No changes were made in this PR triage Needs triage wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge triage Needs triage labels Jan 14, 2026
Copilot AI changed the title [WIP] Update Terraform configuration to include storage type variable Add storage_type variable pass-through to RDS cluster module Jan 14, 2026
Copilot AI requested a review from Benbentwo January 14, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changes No changes were made in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants