Finer Controls for S3 Events Notifications

[ivan-pinatti]

what

Introduce a new variable to have a fine-grained control about the type of S3 Events to trigger the Lambda Notification.

Requires change in underlying Terraform module to be applied first; cloudposse/terraform-aws-datadog-lambda-forwarder#105

why

Default should capture all the Create and Removal events (safer and more compreensive)
AND the variable would provide flexibility to include / remove as needed by users.

references

• Finer Controls for S3 Events Notifications cloudposse/terraform-aws-datadog-lambda-forwarder#105

Summary by CodeRabbit

• New Features
  • Allow configuring which S3 events trigger Datadog Lambda Forwarder notifications for finer control over event handling.
  • Exposed an optional user-configurable list of S3 event types (defaults to none) so deployments can opt in to specific event notifications.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new Terraform variable s3_notification_events (list(string)) and wires it into the datadog_lambda_forwarder module in src/main.tf by passing s3_notification_events = var.s3_notification_events.

Changes

Cohort / File(s)	Change Summary
Terraform variable added src/variables.tf	Introduced variable "s3_notification_events" as list(string) with description "List of S3 events to trigger the Lambda notification" and default [].
Module input propagation src/main.tf	Passed the new variable into the Datadog forwarder module: s3_notification_events = var.s3_notification_events.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble at configs, ears alert and bright,
A new S3 chorus wakes in the night.
Forwarder listens, ready to relay,
Buckets hum and events find their way.
Tiny paws commit — deploy takes flight. 🥕🐇

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Finer Controls for S3 Events Notifications' accurately summarizes the main change: introducing a new variable (s3_notification_events) to provide fine-grained control over S3 event types that trigger Lambda notifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[goruha]

@ivan-pinatti could you pls update the module version to https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/releases/tag/v1.10.0

[ivan-pinatti]

@ivan-pinatti could you pls update the module version to https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/releases/tag/v1.10.0

Done @goruha.

[mergify]

This pull request was marked as a work in progress and looks abandoned.
Feel free to reopen it if you think it's a mistake.

[ivan-pinatti]

This was closed by mistake.

@goruha, could you please reopen and approve it?

[gberenice]

/terratest

[github-actions]

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify]

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[ivan-pinatti]

@goruha, can I get your approval for the merge please?

[mergify]

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[aknysh]

/terratest

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify]

Thanks @ivan-pinatti for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[github-actions]

These changes were released in v1.535.21.