Skip to content

update default python version to match module#91

Merged
aknysh merged 2 commits into
cloudposse-terraform-components:mainfrom
brucex:update-default-python-version
Jan 23, 2026
Merged

update default python version to match module#91
aknysh merged 2 commits into
cloudposse-terraform-components:mainfrom
brucex:update-default-python-version

Conversation

@brucex

@brucex brucex commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

what

python 3.8 is deprecated. make default 3.11 like the module it's calling.

https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/blob/main/variables.tf#L35

We are contacting you as we have identified that your AWS Account currently has one or more AWS Lambda functions using the Python 3.8 runtime. We are ending support for Python 3.8 in Lambda on October 14, 2024. This follows Python 3.8 End-Of-Life (EOL) which is scheduled for October, 2024 [1].

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

Summary by CodeRabbit

  • Chores
    • Updated default Python runtime version to 3.11
    • Updated default Datadog Forwarder version to 3.116.0

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 23, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updated two Terraform variable defaults in src/variables.tf: lambda_runtime from "python3.8" to "python3.11" and dd_forwarder_version from "3.66.0" to "3.116.0". No other code, types, descriptions, or control flow were modified.

Changes

Cohort / File(s) Summary
Terraform variable defaults
src/variables.tf
Changed defaults: lambda_runtime => "python3.11"; dd_forwarder_version => "3.116.0". No signature/type/description changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little hop through code today,
Defaults refreshed in a nimble way,
Runtimes updated, versions bright,
I nibble bugs and sleep at night,
Happy builds and tests take flight! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the default Python version from 3.8 to 3.11, which is the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot requested review from a team January 23, 2026 16:43
@mergify mergify Bot added the triage Needs triage label Jan 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/variables.tf`:
- Around line 25-29: The variable "lambda_runtime" currently defaults to
"python3.11" which is incompatible with Datadog Serverless Forwarder v3.66.0;
either change the default of variable "lambda_runtime" back to "python3.8" or
upgrade the Datadog Forwarder to v3.74.0+ (and confirm any module variable like
datadog_forwarder_version or the module source is updated) so the runtime can be
python3.9+. Update the default in variable "lambda_runtime" or bump the
forwarder version accordingly and verify other references use the same
runtime/version.

Comment thread src/variables.tf
@mergify mergify Bot added the needs-test Needs testing label Jan 23, 2026
@aknysh

aknysh commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

/terratest

@github-actions

Copy link
Copy Markdown

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

@aknysh aknysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @brucex

@aknysh aknysh added this pull request to the merge queue Jan 23, 2026
@mergify mergify Bot removed the triage Needs triage label Jan 23, 2026
Merged via the queue into cloudposse-terraform-components:main with commit 21c40dd Jan 23, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown

These changes were released in v1.535.20.

@brucex brucex deleted the update-default-python-version branch January 23, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-test Needs testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants