update default python version to match module#91
Conversation
📝 WalkthroughWalkthroughUpdated two Terraform variable defaults in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/variables.tf`:
- Around line 25-29: The variable "lambda_runtime" currently defaults to
"python3.11" which is incompatible with Datadog Serverless Forwarder v3.66.0;
either change the default of variable "lambda_runtime" back to "python3.8" or
upgrade the Datadog Forwarder to v3.74.0+ (and confirm any module variable like
datadog_forwarder_version or the module source is updated) so the runtime can be
python3.9+. Update the default in variable "lambda_runtime" or bump the
forwarder version accordingly and verify other references use the same
runtime/version.
|
/terratest |
|
There are no real tests for this component. So we set terratest statuses to successful execution without running any tests |
21c40dd
|
These changes were released in v1.535.20. |
what
python 3.8 is deprecated. make default 3.11 like the module it's calling.
https://github.com/cloudposse/terraform-aws-datadog-lambda-forwarder/blob/main/variables.tf#L35
We are contacting you as we have identified that your AWS Account currently has one or more AWS Lambda functions using the Python 3.8 runtime. We are ending support for Python 3.8 in Lambda on October 14, 2024. This follows Python 3.8 End-Of-Life (EOL) which is scheduled for October, 2024 [1].why
references
closes #123, if this PR closes a GitHub issue#123Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.