fix: use workflow artifacts for library docs in release workflow (#861)

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

Author: milldr

.github/actions/build-website/action.yml

@@ -18,6 +18,9 @@ inputs:
   repo_access_token:
     description: "GitHub Token used to access private repos"
     required: true
+  skip_library_download:
+    description: "Skip downloading library docs from release (use when docs are already present)"
+    default: "false"
 
 runs:
   using: composite
@@ -59,44 +62,42 @@ runs:
       run: |
         make init
 
-    # Download pre-built library docs from draft release or latest published release
+    # Download pre-built library docs from the most recent release (draft or published) that has the asset
     - name: "Download Pre-built Library Docs"
+      if: ${{ inputs.skip_library_download != 'true' }}
       shell: bash
       env:
         GH_TOKEN: ${{ inputs.repo_access_token }}
       run: |
         DOWNLOADED=false
 
-        # Try draft release first
-        echo "Checking for draft release..."
-        DRAFT_TAG=$(gh release list --repo ${{ github.repository }} --exclude-drafts=false --limit 20 | { grep "Draft" || true; } | head -1 | awk -F'\t' '{print $3}')
+        # Get all releases (drafts and published) ordered by most recent first
+        echo "Searching for library-docs.tar.gz in releases..."
+        RELEASES=$(gh release list --repo ${{ github.repository }} --exclude-drafts=false --limit 20 | awk -F'\t' '{print $3}')
 
-        if [ -n "$DRAFT_TAG" ]; then
-          echo "Found draft release: ${DRAFT_TAG}"
-          if gh release download "${DRAFT_TAG}" \
+        if [ -z "$RELEASES" ]; then
+          echo "Error: No releases found. Run the 'Generate Library' workflow first."
+          exit 1
+        fi
+
+        # Iterate through releases until we find one with library-docs.tar.gz
+        for TAG in $RELEASES; do
+          echo "Checking release: ${TAG}"
+          if gh release download "${TAG}" \
                --repo ${{ github.repository }} \
                --pattern "library-docs.tar.gz" \
                --dir /tmp 2>/dev/null; then
-            echo "Downloaded library docs from draft release"
+            echo "Downloaded library docs from release: ${TAG}"
             DOWNLOADED=true
+            break
           else
-            echo "Draft release exists but has no library-docs.tar.gz asset"
+            echo "  No library-docs.tar.gz in ${TAG}, trying next..."
           fi
-        else
-          echo "No draft release found"
-        fi
+        done
 
-        # Fall back to latest published release
         if [ "$DOWNLOADED" = false ]; then
-          echo "Downloading from latest published release..."
-          if ! gh release download \
-                 --repo ${{ github.repository }} \
-                 --pattern "library-docs.tar.gz" \
-                 --dir /tmp; then
-            echo "Error: No library-docs.tar.gz found in any release. Run the 'Generate Library' workflow first."
-            exit 1
-          fi
-          echo "Downloaded library docs from latest published release"
+          echo "Error: No library-docs.tar.gz found in any release. Run the 'Generate Library' workflow first."
+          exit 1
         fi
 
         echo "Extracting library docs..."

.github/workflows/generate-library.yml

@@ -216,6 +216,14 @@ jobs:
             docs/modules/library \
             docs/github-actions/library
 
+      # Upload as workflow artifact for use by calling workflows (e.g., website-deploy-release)
+      - name: Upload Library Docs Artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: library-docs
+          path: library-docs.tar.gz
+          retention-days: 1
+
       - name: Upload to Draft Release
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/website-deploy-release.yml

@@ -45,6 +45,18 @@ jobs:
         with:
           fetch-depth: 0
 
+      # Download library docs generated by the generate-library-docs job
+      - name: Download Library Docs Artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: library-docs
+
+      - name: Extract Library Docs
+        run: |
+          echo "Extracting library docs from workflow artifact..."
+          tar -xzvf library-docs.tar.gz
+          echo "Library docs extracted successfully"
+
       - name: Build Website
         uses: ./.github/actions/build-website
         with:
@@ -54,6 +66,7 @@ jobs:
           google_tag_manager: ${{ env.GOOGLE_TAG_MANAGER }}
           google_site_verification_id: ${{ env.GOOGLE_SITE_VERIFICATION_ID }}
           repo_access_token: ${{ secrets.REPO_ACCESS_TOKEN }}
+          skip_library_download: "true"
 
       # "assets/refarch/handoffs/*" are handled by cloudposse-corp/demos
       - name: Copy Website to S3 Bucket