Replace deprecated parameter for aws_eip resource

[Brandon Metcalf (bwmetcalf)]

what

Replace deprecated

vpc = true

with

domain = "vpc"

for aws_eip resource.

[Brandon Metcalf (bwmetcalf)]

Kevin (@kevcube) RB (@nitrocode) I know this module is deprecated, but we still have a few places where we are using in and switching to https://github.com/cloudposse/terraform-aws-dynamic-subnets would be a bigger lift for us right now.

[Kevin (kevcube)]

/terratest

[Brandon Metcalf (bwmetcalf)]

Kevin (@kevcube) Anything else needed here? It doesn't look like the tests are running.

[Kevin (kevcube)]

/terratest

[Brandon Metcalf (bwmetcalf)]

It looks like the outputs test is picking up examples/complete/outputs.tf as outputs.tf doesn't contain the variables the test is complaining about.

[Kevin (kevcube)]

It looks like the outputs test is picking up examples/complete/outputs.tf as outputs.tf doesn't contain the variables the test is complaining about.

If you fix I'll review in the morning

[Brandon Metcalf (bwmetcalf)]

/terratest

[Kevin (kevcube)]

/terratest

[Ritesh Tiwari (riteshtiwari2000)]

Hi, is anyone merging these changes? My TF deployment is stuck because of this.