💡 create teams as closed, set description

* Closes #10
  (It appears to be possible to create private teams)

Author: JoshuaTheMiller

src/services/gitHub.ts

@@ -264,10 +264,12 @@ class InstalledGitHubClient implements InstalledClient {
         }
     }
 
-    public async CreateTeam(team: GitHubTeamName): Response<any> {
+    public async CreateTeam(team: GitHubTeamName, description:string): Response<any> {
         await this.gitHubClient.rest.teams.create({
             name: team,
-            org: this.orgName
+            org: this.orgName,
+            description,
+            privacy:"closed"
         })
 
         return {
@@ -328,7 +330,7 @@ class InstalledGitHubClient implements InstalledClient {
             org: this.orgName,
             privacy: "closed",
             team_slug: team,
-            description: description
+            description: description            
         })
 
         return {

src/services/gitHubTypes.ts

@@ -18,7 +18,7 @@ export interface InstalledClient {
     IsUserMember(id: GitHubId): Response<boolean>
     GetAllTeams(): Response<GitHubTeamId[]>
     AddTeamMember(team: GitHubTeamName, id: GitHubId): Response
-    CreateTeam(teamName: GitHubTeamName): Response
+    CreateTeam(teamName: GitHubTeamName, description:string): Response
     DoesUserExist(gitHubId: string): Response<GitHubId>
     ListCurrentMembersOfGitHubTeam(team: GitHubTeamName): Response<GitHubId[]>
     RemoveTeamMemberAsync(team: GitHubTeamName, user: GitHubId): Response

src/services/githubSync.ts

@@ -71,6 +71,8 @@ async function SynchronizeOrgMembers(installedGitHubClient: InstalledClient, tea
 }
 
 async function SynchronizeGitHubTeam(installedGitHubClient: InstalledClient, teamName: string, config: AppConfig, existingMembers: GitHubId[]) {    
+    await installedGitHubClient.UpdateTeamDetails(teamName, teamDescription);
+
     const trueMembersList = await GetGitHubIds(teamName, config);
     const orgName = installedGitHubClient.GetCurrentOrgName();
 
@@ -102,9 +104,7 @@ async function SynchronizeGitHubTeam(installedGitHubClient: InstalledClient, tea
     }
 
     const validMemberCheckResults = await Promise.all(trueMembersList.map(tm => checkValidOrgMember(tm)));
-    const trueValidTeamMembersList: string[] = validMemberCheckResults.filter(r => r.successful).map(r => r.gitHubId);
-
-    await installedGitHubClient.UpdateTeamDetails(teamName, teamDescription);
+    const trueValidTeamMembersList: string[] = validMemberCheckResults.filter(r => r.successful).map(r => r.gitHubId);    
 
     const listMembersResponse = await installedGitHubClient.ListCurrentMembersOfGitHubTeam(teamName);
 
@@ -148,7 +148,7 @@ export async function SyncOrg(installedGitHubClient: InstalledClient, config: Ap
         for (let t of config.SecurityManagerTeams) {
             if(!setOfExistingTeams.has(t.toUpperCase())) {
                 console.log(`Creating team '${orgName}/${t}'`)
-                await installedGitHubClient.CreateTeam(t); 
+                await installedGitHubClient.CreateTeam(t, teamDescription); 
                 setOfExistingTeams.add(t);
             }
 
@@ -183,7 +183,7 @@ export async function SyncOrg(installedGitHubClient: InstalledClient, config: Ap
     if(teamsToCreate.length > 0) {
         for(let t of teamsToCreate) {
             console.log(`Creating team '${orgName}/${t}'`)
-            await installedGitHubClient.CreateTeam(t); 
+            await installedGitHubClient.CreateTeam(t, teamDescription); 
         }
     }