Skip to content

Commit dd8c5fc

Browse files
Propagate options to Azure facade
1 parent 5461a50 commit dd8c5fc

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

source/GitHubApp/ActiveDirectoryFacadeFactory.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,34 @@
66

77
internal class ActiveDirectoryFacadeFactory : IActiveDirectoryFacadeFactory
88
{
9-
private readonly IOptions<AzureOptions> azureOptions;
9+
private readonly AzureOptions azureOptions;
1010

1111
public ActiveDirectoryFacadeFactory(IOptions<AzureOptions> azureOptions)
1212
{
13-
this.azureOptions = azureOptions;
13+
this.azureOptions = azureOptions.Value;
1414
}
1515

1616
public IActiveDirectoryFacade GetActiveDirectoryClient()
1717
{
18-
var tenantId = azureOptions.Value.TenantId;
19-
var clientId = azureOptions.Value.ClientId;
20-
var clientSecret = azureOptions.Value.ClientSecret;
18+
var tenantId = azureOptions.TenantId;
19+
var clientId = azureOptions.ClientId;
20+
var clientSecret = azureOptions.ClientSecret;
2121

2222
// The client credentials flow requires that you request the
2323
// /.default scope, and preconfigure your permissions on the
2424
// app registration in Azure. An administrator must grant consent
2525
// to those permissions beforehand.
2626
var scopes = new[] { "https://graph.microsoft.com/.default" };
2727
// using Azure.Identity;
28-
var options = new TokenCredentialOptions
28+
var options = new ClientSecretCredentialOptions
2929
{
3030
AuthorityHost = AzureAuthorityHosts.AzurePublicCloud
3131
};
3232
// https://docs.microsoft.com/dotnet/api/azure.identity.clientsecretcredential
3333
var clientSecretCredential = new ClientSecretCredential(
3434
tenantId, clientId, clientSecret, options);
3535
var graphClient = new GraphServiceClient(clientSecretCredential);
36-
var activeDirectoryFacade = new ActiveDirectoryFacade(graphClient);
36+
var activeDirectoryFacade = new ActiveDirectoryFacade(graphClient, azureOptions);
3737

3838
return activeDirectoryFacade;
3939
}

source/Gttsb.Gh/ActiveDirectoryFacade.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ namespace Gttsb.Gh
66
public sealed class ActiveDirectoryFacade : IActiveDirectoryFacade
77
{
88
private readonly GraphServiceClient _graphServiceClient;
9+
private readonly AzureOptions _azureOptions;
910

10-
public ActiveDirectoryFacade(GraphServiceClient graphServiceClient)
11+
public ActiveDirectoryFacade(GraphServiceClient graphServiceClient, AzureOptions azureOptions)
1112
{
1213
_graphServiceClient = graphServiceClient;
14+
_azureOptions = azureOptions;
1315
}
1416

1517
public async Task<MembersResponse> FetchMembersAsync(string groupDisplayName)

0 commit comments

Comments
 (0)