More logging enhancements

Author: JoshuaTheMiller

package.json

@@ -20,6 +20,7 @@
     "@types/js-yaml": "^4.0.5",
     "@types/ldap-escape": "^2.0.0",
     "@types/ldapjs": "^2.2.5",
+    "@types/node": "^20.4.8",
     "@types/swagger-ui-express": "^4.1.3",
     "nodemon": "^2.0.21",
     "shx": "^0.3.4",

src/logging.ts

@@ -1,6 +1,6 @@
 const appInsights = require("applicationinsights");
 
-import { SeverityLevel, TelemetryType } from "applicationinsights/out/Declarations/Contracts";
+import { SeverityLevel } from "applicationinsights/out/Declarations/Contracts";
 import TelemetryClient from "applicationinsights/out/Library/TelemetryClient";
 
 interface ILogger {
@@ -51,8 +51,8 @@ export function LogError(ex: string) {
 export function SetupLogging() {
     if(process.env.APPLICATIONINSIGHTS_CONNECTION_STRING) {
         console.log("Using AppInsights Logger")
-        appInsights.setup(process.env.APPLICATIONINSIGHTS_CONNECTION_STRING).start();
-    
+        appInsights.setup(process.env.APPLICATIONINSIGHTS_CONNECTION_STRING).start();        
+
         const telemetryClient = appInsights.defaultClient;
 
         logger = new AiLogger(telemetryClient);

src/services/ldapClient.ts

@@ -97,7 +97,9 @@ async function SearchAllAsyncNoExceptionHandling(groupName: string): SearchAllRe
         });
 
         response.on('end', (result: any) => {
-            if (result.status !== 0) {
+            Log(`Search Ended for Group '${groupName}' with result '${JSON.stringify(result)}'`)
+
+            if (result?.status !== 0 || result == null || result == undefined) {
                 return reject(result.status);
             }
 
@@ -109,7 +111,7 @@ async function SearchAllAsyncNoExceptionHandling(groupName: string): SearchAllRe
         });
 
         response.on('error', (err: any) => {
-            Log('error: ' + err.message);
+            LogError(`Search Errored for Group '${groupName}': ${JSON.stringify(err)}`);
             return reject();
         });