fix: Update client gen#6
Merged
Merged
Conversation
disq
force-pushed
the
fix/update-client-gen
branch
from
ec5ccdc to
0415cdf
Compare
Comment on lines
-11
to
-20
| @command -v openapi-generator >/dev/null 2>&1 || { \ | ||
| echo "Error: 'openapi-generator' command not found. Please install it before running convert-spec."; \ | ||
| echo "On MacOS you can use Homebrew: brew install openapi-generator"; \ | ||
| echo "You can install it by following the instructions at: https://github.com/OpenAPITools/openapi-generator?tab=readme-ov-file#1---installation"; \ | ||
| exit 1; \ | ||
| } | ||
| openapi-generator generate -g openapi -i spec.json -o .openapi-tmp | ||
| mv .openapi-tmp/openapi.json spec.json | ||
| rm -rf .openapi-tmp | ||
| go generate ./... No newline at end of file |
Contributor
There was a problem hiding this comment.
Let's keep this? I think it was there to prevent a run of this wiping out your local changes to yaml files that you forgot to include in a path
Member
Author
There was a problem hiding this comment.
go generate only generates (client|models).gen.go and doesn't touch any files otherwise I think.
The wiping happens with redocly.
hermanschaaf
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates client generation to be on par with other places.
Combines models and client files.
Uses the updated spec.json from the clean up PR in the platform.