Skip to content

fix: Add time delay in DeleteStaleAll test for destinations #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jun 18, 2025
Merged

fix: Add time delay in DeleteStaleAll test for destinations #2191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107e6b7
fix: Add time delay in DeleteStaleAll test for destinations
maaarcelino Jun 18, 2025
c44760f
refactor other test
maaarcelino Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugin/testing_write_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ func (s *WriterTestSuite) testDeleteStaleBasic(ctx context.Context, t *testing.T
r.EqualValuesf(1, TotalRows(records), "unexpected amount of items after delete stale")
r.Emptyf(RecordsDiff(table.ToArrowSchema(), records, []arrow.Record{record1}), "record differs after delete stale")

syncTime = syncTime.Add(time.Second)
bldr.Field(0).(*array.Int64Builder).Append(1)
bldr.Field(1).(*array.StringBuilder).Append(sourceName)
bldr.Field(2).(*array.TimestampBuilder).AppendTime(syncTime.Add(time.Second))
bldr.Field(2).(*array.TimestampBuilder).AppendTime(syncTime)
record2 := bldr.NewRecord()

r.NoErrorf(s.plugin.writeOne(ctx, &message.WriteInsert{Record: record2}), "failed to insert second record")
Expand All @@ -70,7 +71,7 @@ func (s *WriterTestSuite) testDeleteStaleBasic(ctx context.Context, t *testing.T
r.NoErrorf(s.plugin.writeOne(ctx, &message.WriteDeleteStale{
TableName: table.Name,
SourceName: sourceName,
SyncTime: syncTime.Add(time.Second),
SyncTime: syncTime,
}), "failed to delete stale records second time")

records, err = s.plugin.readAll(ctx, table)
Expand Down Expand Up @@ -117,7 +118,7 @@ func (s *WriterTestSuite) testDeleteStaleAll(ctx context.Context, t *testing.T)
r.EqualValuesf(rowsPerRecord, TotalRows(readRecords), "unexpected amount of items after delete stale")

// https://github.com/golang/go/issues/41087
syncTime = time.Now().UTC().Truncate(time.Microsecond)
syncTime = syncTime.Add(time.Second)
nullRecord := tg.Generate(table, schema.GenTestDataOptions{
MaxRows: rowsPerRecord,
TimePrecision: s.genDatOptions.TimePrecision,
Expand All @@ -144,6 +145,7 @@ func (s *WriterTestSuite) testDeleteStaleAll(ctx context.Context, t *testing.T)
readRecords, err = s.plugin.readAll(ctx, table)
r.NoErrorf(err, "failed to read after second delete stale")
sortRecords(table, readRecords, "id")

r.EqualValuesf(rowsPerRecord, TotalRows(readRecords), "unexpected amount of items after second delete stale")
r.Emptyf(RecordsDiff(table.ToArrowSchema(), readRecords, []arrow.Record{nullRecord}), "record differs")
}
Expand Down