Skip to content

fix: BatchWriter: Ensure flushed batch has at least one record #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Apr 29, 2026
+54 −2
Merged

fix: BatchWriter: Ensure flushed batch has at least one record #2489

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d61d6
Update batchwriter.go
bbernays Apr 27, 2026
922979e
test: add regression test for empty WriteTableBatch guard
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions writers/batchwriter/batchwriter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,9 @@ func (w *BatchWriter) worker(ctx context.Context, tableName string, ch <-chan *m
limit.AddSlice(add)
}
if len(toFlush) > 0 || rest != nil || limit.ReachedLimit() {
// flush current batch
send()
if limit.Rows() > 0 {
send()
}
Comment thread
bbernays marked this conversation as resolved.
ticker.Reset(w.batchTimeout)

@disq disq Apr 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go inside the if as well?

@erezrokah erezrokah Apr 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or have batch.SliceRecord return toFlush = 0?

@bbernays bbernays Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to reset the batchTimeout even if there were no resources to ensure that we don't just sync a single row the next time

}
for _, sliceToFlush := range toFlush {
Expand Down
Loading