Commit 1846211
fix(review): address PR #318 review feedback
- entry.py: add standard "# Copyright 2026 Cloudsmith Ltd" header
(Copilot) — matches the convention used by other new modules.
- cloudsmith.spec: add the same header after the mode/coding magic line
(Copilot).
- Declined (Copilot, spec lines 12 & 35): "Analysis(['entry.py']) will
fail when PyInstaller runs from the repo root." PyInstaller resolves
relative script paths in Analysis() against the spec file's directory
(SPECPATH), not the CWD. Reproduced a full build from the repo root
(the exact workflow invocation) — PyInstaller logged
"Analyzing .../packaging/pyinstaller/entry.py" and the build
completed successfully. No HERE/pathex change needed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 0f6f738 commit 1846211
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
0 commit comments