Skip to content

Commit 1846211

Browse files
fix(review): address PR #318 review feedback
- entry.py: add standard "# Copyright 2026 Cloudsmith Ltd" header (Copilot) — matches the convention used by other new modules. - cloudsmith.spec: add the same header after the mode/coding magic line (Copilot). - Declined (Copilot, spec lines 12 & 35): "Analysis(['entry.py']) will fail when PyInstaller runs from the repo root." PyInstaller resolves relative script paths in Analysis() against the spec file's directory (SPECPATH), not the CWD. Reproduced a full build from the repo root (the exact workflow invocation) — PyInstaller logged "Analyzing .../packaging/pyinstaller/entry.py" and the build completed successfully. No HERE/pathex change needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 0f6f738 commit 1846211

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

packaging/pyinstaller/cloudsmith.spec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- mode: python ; coding: utf-8 -*-
2+
# Copyright 2026 Cloudsmith Ltd
23
# PyInstaller onedir spec for the Cloudsmith CLI. Built natively per target.
34
# onedir (not onefile): onefile re-extracts the whole bundle on every
45
# invocation (~6s/run); onedir starts in ~0.4s. Distributed as tar.gz/zip.

packaging/pyinstaller/entry.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# Copyright 2026 Cloudsmith Ltd
12
import importlib
23
import os
34
import pkgutil

0 commit comments

Comments
 (0)