-
Notifications
You must be signed in to change notification settings - Fork 12
Cloudsmith io/shivani generic upstream GitHub releases #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| import styles from './Table.module.css'; | ||
|
|
||
| export function Table(props: React.ComponentPropsWithoutRef<'table'>) { | ||
| return <table className={styles.root} {...props} />; | ||
| return ( | ||
| <div className={styles.container}> | ||
| <table className={styles.root} {...props} /> | ||
| </div> | ||
| ); | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -233,9 +233,11 @@ In the upstream creation menu, define a name for your upstream and enter the ups | |||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Please see our [Upstream Proxying](/repositories/upstreams#create-a-generic-upstream) documentation for further instructions on configuring upstreams. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ### Example: Node.js Distributions | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ### Examples | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| This example demonstrates how upstream URLs, prefixes, and file paths work together. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| #### Node.js Distributions | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| This example demonstrates how upstream URLs, prefixes, and file paths are applied when working with Node.js distributions. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Upstream configuration:** | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - **Upstream URL**: `https://nodejs.org/dist/` | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -261,6 +263,33 @@ curl -sLf -O 'https://generic.cloudsmith.io/OWNER/REPOSITORY/node_distributions/ | |||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| The upstream prefix (`node_distributions`) ensures files from Node.js don't collide with files from other upstreams, even if they share identical file paths. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| #### Github Releases | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| #### Github Releases | |
| #### GitHub Releases |
Copilot
AI
Apr 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub Releases example currently uses the GitHub API endpoint (https://api.github.com/repos/.../releases) as the upstream base, but release assets are not downloadable by appending /<tag>/<asset> to that API URL (the endpoint returns JSON and .../releases/v0.x/... will 404). Update the example to use a download-able base URL (e.g., https://github.com/<owner>/<repo>/releases/download/) and adjust the “Full upstream URL” row/path explanation accordingly so the resolved URL matches the actual asset URL format (.../releases/download/<tag>/<asset>).
| - **Upstream URL**: `https://api.github.com/repos/<owner>/<repo>/releases` | |
| - **Upstream Prefix**: `github_releases` | |
| **How paths are resolved:** | |
| The upstream URL includes the base path (`/releases/`), so file paths are relative to that location. | |
| To download `https://github.com/aquasecurity/trivy/releases/download/v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz`, request the path `v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` from Cloudsmith: | |
| | Component | Value | | |
| | :-------- | :---- | | |
| | Upstream URL | `https://api.github.com/repos/aquasecurity/trivy/releases` | | |
| | File path on upstream | `v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` | | |
| | Full upstream URL | `https://api.github.com/repos/aquasecurity/trivy/releases/v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` | | |
| - **Upstream URL**: `https://github.com/<owner>/<repo>/releases/download/` | |
| - **Upstream Prefix**: `github_releases` | |
| **How paths are resolved:** | |
| The upstream URL includes the base path (`/releases/download/`), so file paths are appended after that location. | |
| To download `https://github.com/aquasecurity/trivy/releases/download/v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz`, request the path `v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` from Cloudsmith: | |
| | Component | Value | | |
| | :-------- | :---- | | |
| | Upstream URL | `https://github.com/aquasecurity/trivy/releases/download/` | | |
| | File path on upstream | `v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` | | |
| | Full upstream URL | `https://github.com/aquasecurity/trivy/releases/download/v0.69.3/trivy_0.69.3_Linux-ARM64.tar.gz` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new scroll container enables horizontal scrolling, but a plain
<div>withoverflow-x: autoisn’t keyboard-focusable by default, which makes horizontal scrolling difficult for keyboard-only users. Consider making the container focusable (e.g.,tabIndex={0}) and giving it an accessible name (viaaria-label/aria-labelledby, potentially reusing the table’s labeling props) so assistive tech users can discover and operate the scroll region.