Skip to content

Commit e17a4f9

Browse files
authored
Update integration-testing.yml
1 parent c9f6dcb commit e17a4f9

1 file changed

Lines changed: 19 additions & 16 deletions

File tree

.github/workflows/integration-testing.yml

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,29 +27,32 @@ jobs:
2727
with:
2828
repository: googleapis/python-bigquery-magics
2929
path: python-bigquery-magics
30-
30+
3131
- name: Install and test
3232
run: |
3333
set -e
3434
python -m venv venv
3535
. venv/bin/activate
3636
pip install pytest
37-
38-
# Install the local build (from your PR) into the venv
39-
pip install dist/*.whl
40-
41-
# Remove the source directory to prevent sys.path conflicts.
42-
# The tests will use the package just installed from the wheel.
43-
rm -rf spanner_graph_notebook
44-
45-
# Install bigquery-magics with the correct extras
46-
# to run all graph and storage-related tests.
47-
pip install ./python-bigquery-magics
48-
37+
38+
# We don't install the wheel directly. Instead, we'll tell pip to look
39+
# in the 'dist' directory when it resolves dependencies.
40+
41+
# Install bigquery-magics and its extras.
42+
# The --find-links flag tells pip to look in the local dist/ directory
43+
# for packages before going to PyPI. This will make it pick up
44+
# the locally built wheel to satisfy the 'spanner-graph-notebook' dependency.
45+
pip install --find-links=dist ./python-bigquery-magics[spanner-graph-notebook]
46+
47+
# The comment in the original file about removing the source directory to
48+
# prevent path conflicts was a good idea, but the command was incorrect.
49+
# This removes the 'spanner_graphs' source package directory.
50+
rm -rf spanner_graphs
51+
4952
pip install google-cloud-testutils
50-
53+
5154
# Change directory into the bigquery-magics checkout
5255
cd python-bigquery-magics
53-
56+
5457
# Run the tests from within its own directory
55-
pytest -v tests/unit/test_graph_server.py tests/unit/bigquery/test_bigquery.py
58+
pytest -v tests/unit/test_graph_server.py tests/unit/bigquery/test_bigquery.py

0 commit comments

Comments
 (0)