Merge pull request #187 from cloudspannerecosystem/revert-allow-commit-timestamp-tmplate

fix: disable automatic CommitTimestamp injection in default template

Author: sinmetal

templates/type.go.tpl

@@ -74,9 +74,7 @@ func ({{ $short }} *{{ .Name }}) columnsToValues(cols []string) ([]interface{},
 {{- range .Fields }}
     {{- if not .Col.IsHidden }}
 		case "{{ colname .Col }}":
-		    {{- if .Col.IsAllowCommitTimestamp }}
-		    ret = append(ret, spanner.CommitTimestamp)
-			{{- else if .CustomType }}
+			{{- if .CustomType }}
 			ret = append(ret, {{ .Type }}({{ $short }}.{{ .Name }}))
 			{{- else }}
 			ret = append(ret, {{ $short }}.{{ .Name }})

test/testdata/schema.sql

@@ -119,6 +119,8 @@ CREATE TABLE GeneratedColumns (
 
 CREATE TABLE AllowCommitTimestamp (
   ID INT64 NOT NULL,
+  EndsAt TIMESTAMP OPTIONS (allow_commit_timestamp=true),
+  CreatedAt TIMESTAMP NOT NULL OPTIONS (allow_commit_timestamp=true),
   UpdatedAt TIMESTAMP NOT NULL OPTIONS (allow_commit_timestamp=true)
 ) PRIMARY KEY(ID);