implement isSysPkg by package

Author: angrychow

lang/golang/parser/utils.go

@@ -19,14 +19,12 @@ import (
 	"bytes"
 	"container/list"
 	"fmt"
-	"github.com/cloudwego/abcoder/lang/log"
 	"go/ast"
+	"go/build"
 	"go/types"
 	"io"
 	"os"
-	"os/exec"
 	"path"
-	"path/filepath"
 	"regexp"
 	"strings"
 	"sync"
@@ -109,55 +107,20 @@ func (pc *PackageCache) Set(key string, value bool) {
 	pc.cache[key] = elem
 }
 
-var (
-	gorootOnce     sync.Once
-	detectedGoRoot string
-	gorootErr      error
-)
-
-// getGoRoot 获取 go root 环境变量。
-func getGoRoot() (string, error) {
-	gorootOnce.Do(func() {
-		cmd := exec.Command("go", "env", "GOROOT")
-		var out bytes.Buffer
-		var stderr bytes.Buffer
-		cmd.Stdout = &out
-		cmd.Stderr = &stderr
-		err := cmd.Run()
-		if err != nil {
-			log.Info("'go env GOROOT' failed: %v, stderr: %s; \n `isSysPkg` will downgrade.", err, stderr.String())
-			gorootErr = fmt.Errorf("'go env GOROOT' failed: %w, stderr: %s", err, stderr.String())
-			return
-		}
-
-		gorootPath := strings.TrimSpace(out.String())
-		if gorootPath == "" {
-			log.Info("'go env GOROOT' returns a empty string \n `isSysPkg` will downgrade.")
-			gorootErr = fmt.Errorf("'go env GOROOT' returns a empty string")
-			return
-		}
-		detectedGoRoot = gorootPath
-	})
-	return detectedGoRoot, gorootErr
-}
-
 // IsStandardPackage 检查一个包是否为标准库，并使用内部缓存。
 func (pc *PackageCache) IsStandardPackage(path string) bool {
 	if isStd, found := pc.Get(path); found {
 		return isStd
 	}
 
-	goRoot, err := getGoRoot()
-	// 当前环境找不到 go root，退化到最简单判断
-	var isStd bool
-	if err != nil || goRoot == "" {
-		isStd = !strings.Contains(strings.Split(path, "/")[0], ".")
-	} else {
-		pkgPath := filepath.Join(goRoot, "src", path)
-		_, err = os.Stat(pkgPath)
-		isStd = !os.IsNotExist(err)
+	pkg, err := build.Import(path, "", build.FindOnly)
+	if err != nil {
+		// Cannot find the package, assume it's not a standard package
+		pc.Set(path, false)
+		return false
 	}
 
+	isStd := pkg.Goroot
 	pc.Set(path, isStd)
 	return isStd
 }

lang/golang/parser/utils_test.go

@@ -15,7 +15,6 @@
 package parser
 
 import (
-	"github.com/stretchr/testify/assert"
 	"go/ast"
 	"go/importer"
 	"go/parser"
@@ -25,6 +24,8 @@ import (
 	"sync"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/stretchr/testify/require"
 )
 
@@ -199,11 +200,6 @@ var f func() (*http.Request, error)`,
 }
 
 func resetGlobals() {
-	// 重置 GOROOT 的 sync.Once 和其缓存的变量
-	gorootOnce = sync.Once{}
-	detectedGoRoot = ""
-	gorootErr = nil
-
 	// 重置包缓存
 	stdlibCache = NewPackageCache(10000)
 }
@@ -236,33 +232,6 @@ func Test_isSysPkg(t *testing.T) {
 		}
 	})
 
-	// 测试在 `go env GOROOT` 执行失败时的行为
-	t.Run("Group: Fallback Path - GOROOT is not found", func(t *testing.T) {
-		resetGlobals()
-
-		// 使用 t.Setenv 临时清空 PATH，使得 "go" 命令无法被找到
-		t.Setenv("PATH", "")
-
-		testCases := []struct {
-			name       string
-			importPath string
-			want       bool
-		}{
-			{"standard library package (fallback)", "fmt", true},
-			{"nested standard library package (fallback)", "os/exec", true},
-			{"third-party package (fallback)", "github.com/google/uuid", false},
-			{"local-like package name (fallback)", "myproject/utils", true}, // 在降级模式下，被错误地判断为 true
-		}
-
-		for _, tc := range testCases {
-			t.Run(tc.name, func(t *testing.T) {
-				if got := isSysPkg(tc.importPath); got != tc.want {
-					t.Errorf("isSysPkg(%q) in fallback mode = %v, want %v", tc.importPath, got, tc.want)
-				}
-			})
-		}
-	})
-
 	// 测试并发调用时的行为
 	t.Run("Group: Concurrency Test", func(t *testing.T) {
 		resetGlobals()