fix(openai): merge ExtraFields in WithExtraFields instead of overwriting#793
Open
wucm667 wants to merge 2 commits into
Open
fix(openai): merge ExtraFields in WithExtraFields instead of overwriting#793wucm667 wants to merge 2 commits into
wucm667 wants to merge 2 commits into
Conversation
When multiple WithExtraFields options are passed, the later call overwrites the earlier fields instead of merging them. This prevents combining framework-provided config (like EnableThinking) with user-provided fields (like enable_search). Fix by merging extraFields into o.ExtraFields instead of replacing.
Author
|
Hi! The All actual tests pass successfully: Could someone with repo admin access check the workflow permissions? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #671
When multiple
WithExtraFieldsoptions are passed, later calls overwrite earlier fields instead of merging. This prevents combining framework-provided config (e.g.,EnableThinking) with user-provided fields (e.g.,enable_search).Changes
libs/acl/openai/option.go — Changed
WithExtraFieldsto merge fields intoo.ExtraFieldsinstead of direct assignment:libs/acl/openai/option_test.go — Added test case
"WithExtraFields merges on multiple calls"verifying that two consecutive calls produce merged fields.Files Changed
libs/acl/openai/option.golibs/acl/openai/option_test.go