fix(ollama): include items structure in tool parameter definitions#797
Open
wucm667 wants to merge 1 commit intocloudwego:mainfrom
Open
fix(ollama): include items structure in tool parameter definitions#797wucm667 wants to merge 1 commit intocloudwego:mainfrom
wucm667 wants to merge 1 commit intocloudwego:mainfrom
Conversation
When converting tool parameters to Ollama API format, array-type parameters were missing their nested items structure. Add a recursive schemaToToolProperty helper to handle Items, AnyOf, and other nested schema fields. Fixes cloudwego#716
a415e5a to
0667c3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using Ollama ChatModel with tools that have array-type parameters, the
itemsstructure is missing in the tool definition sent to the Ollama API. This causes the model to lack schema information for array elements.For example, a tool parameter
Messages []*messageis serialized as:{ "messages": { "type": "array", "description": "Messages to test." } }Instead of the expected:
{ "messages": { "items": { "properties": { "title": { "description": "...", "type": "string" }, "content": { "description": "...", "type": "string" } }, "type": "object" }, "type": "array", "description": "Messages to test." } }Fix
Add a recursive
schemaToToolPropertyhelper that converts*jsonschema.Schematoapi.ToolProperty, properly handling:Type/TypeEnhancedItems(recursive for array element types)AnyOf(recursive for union types)Description,EnumReplaces the previous flat property construction that only handled top-level
Type,Description, andEnum.Closes #716