fix(ttstream): ttstream should not recycle connection when Recv timeout with DisableCancelRemote=true#1952
Merged
DMwangnima merged 1 commit intoApr 24, 2026
Conversation
a773ee9 to
4333920
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 61.37% 62.84% +1.46%
==========================================
Files 388 394 +6
Lines 35063 30267 -4796
==========================================
- Hits 21521 19020 -2501
+ Misses 12247 9950 -2297
- Partials 1295 1297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1233f1 to
44971cb
Compare
DMwangnima
commented
Apr 24, 2026
DMwangnima
commented
Apr 24, 2026
d8d6f38 to
28d99c2
Compare
…ction recycling when DisableCancelRemote=true - Separate RecvTimeout (per-Recv deadline, code 12014) from StreamTimeout (stream ctx deadline, code 12015) so that a recv timeout with DisableCancelRemote=true does not close the stream or recycle the connection - Add canRetry mechanism to Exception: when DisableCancelRemote=true, recv timeout errors are marked retryable and streamReader does not persist the error, allowing subsequent Recv calls to continue - Refactor Pipe: bind ctx and callback at construction time, add ReadCtx for per-read ctx/callback, remove Cancel()/pipeStateCanceled, move container package to internal - RecvMsg now uses context.Background() to derive recv timeout ctx, making it independent from stream ctx
28d99c2 to
b2405e4
Compare
AsterDY
approved these changes
Apr 24, 2026
YangruiEmma
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
so that a recv timeout with DisableCancelRemote=true does not close the stream or recycle the connection
and streamReader does not persist the error, allowing subsequent Recv calls to continue
remove Cancel()/pipeStateCanceled, move container package to internal
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: