Skip to content

Commit 7fb3231

Browse files
authored
Merge pull request clue#53 from clue-labs/phpunit8
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5
2 parents 0b6b9b0 + 3eb1eed commit 7fb3231

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ jobs:
3333
coverage: xdebug
3434
ini-file: development
3535
- run: composer install
36-
- run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml
37-
if: ${{ matrix.php >= 7.3 }}
38-
- run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml -c phpunit.xml.legacy
39-
if: ${{ matrix.php < 7.3 }}
36+
- run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml ${{ matrix.php < 7.3 && '-c phpunit.xml.legacy' || '' }}
4037
- name: Check 100% code coverage
4138
shell: php {0}
4239
run: |

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"react/promise": "^3 || ^2.2.1 || ^1.2.1"
1616
},
1717
"require-dev": {
18-
"phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
18+
"phpunit/phpunit": "^9.6 || ^8.5 || ^5.7 || ^4.8.36",
1919
"react/async": "^4 || ^3 || ^2",
2020
"react/event-loop": "^1.2",
2121
"react/http": "^1.8"

0 commit comments

Comments
 (0)