Update integration tests to use extended grep instead of PCRE#149
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the bash-based integration test script to avoid grep -P (PCRE) and instead use extended regular expressions, improving portability across environments where PCRE grep isn’t available.
Changes:
- Replace
grep -iP ...patterns withgrep -iE ...equivalents (and adjust patterns/anchors accordingly). - Update the curl wrapper to call the external
curlbinary viacommandand normalize CRLF output. - Modernize bash arithmetic from
$[...]to$((...)).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the integration tests to use the more widely supported extended grep instead of PCRE. Among others, this makes it easier to run these tests across different platforms, including macOS and Alpine Linux.
Builds on top of clue/framework-x#283, https://github.com/clue-engineering/check-domains/pull/62 (private) and #136