Skip to content

Commit 7ad8a28

Browse files
authored
Merge pull request #66 from clue-labs/phpunit8
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5
2 parents 7353a03 + 2b4f466 commit 7ad8a28

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,7 @@ jobs:
3232
php-version: ${{ matrix.php }}
3333
coverage: xdebug
3434
- run: composer install
35-
- run: vendor/bin/phpunit --coverage-text
36-
if: ${{ matrix.php >= 7.3 }}
37-
- run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
38-
if: ${{ matrix.php < 7.3 }}
35+
- run: vendor/bin/phpunit --coverage-text ${{ matrix.php < 7.3 && '-c phpunit.xml.legacy' || '' }}
3936

4037
PHPUnit-hhvm:
4138
name: PHPUnit (HHVM)

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"ringcentral/psr7": "^1.2"
1818
},
1919
"require-dev": {
20-
"phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
20+
"phpunit/phpunit": "^9.6 || ^8.5 || ^5.7 || ^4.8.36",
2121
"react/async": "^4.3 || ^3 || ^2",
2222
"react/event-loop": "^1.2",
2323
"react/http": "^1.11",

0 commit comments

Comments
 (0)