Skip to content

Commit d518c59

Browse files
authored
Merge pull request #120 from clue-labs/phpunit8
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5
2 parents d6c1311 + 3dd2e48 commit d518c59

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ jobs:
3131
php-version: ${{ matrix.php }}
3232
coverage: xdebug
3333
- run: composer install
34-
- run: vendor/bin/phpunit --coverage-text
35-
if: ${{ matrix.php >= 7.3 }}
36-
- run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
37-
if: ${{ matrix.php < 7.3 }}
34+
- run: vendor/bin/phpunit --coverage-text ${{ matrix.php < 7.3 && '-c phpunit.xml.legacy' || '' }}
3835

3936
PHPUnit-hhvm:
4037
name: PHPUnit (HHVM)

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require-dev": {
1919
"clue/block-react": "^1.5",
2020
"clue/connection-manager-extra": "^1.3",
21-
"phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
21+
"phpunit/phpunit": "^9.6 || ^8.5 || ^5.7 || ^4.8.36",
2222
"react/event-loop": "^1.2",
2323
"react/http": "^1.6"
2424
},

0 commit comments

Comments
 (0)