Close pipe

simonlindholm · simonlindholm · commit 3e4700c1a492 · 2026-05-30T23:58:41.000+02:00
diff --git a/cms/grading/tasktypes/interactive_keeper.py b/cms/grading/tasktypes/interactive_keeper.py
@@ -163,8 +163,7 @@ def main():
                 wait=False,
             )
 
-            # We do not close p["c_to_u"][0] -- it only risks crashing the
-            # controller with SIGPIPE if the submission exits early.
+            os.close(p["c_to_u"][0])
             os.close(p["u_to_c"][1])
 
             try:

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,7 @@ def main():`
`163`	`163`	`wait=False,`
`164`	`164`	`)`
`165`	`165`
`166`		`- # We do not close p["c_to_u"][0] -- it only risks crashing the`
`167`		`- # controller with SIGPIPE if the submission exits early.`
	`166`	`+ os.close(p["c_to_u"][0])`
`168`	`167`	`os.close(p["u_to_c"][1])`
`169`	`168`
`170`	`169`	`try:`