Skip to content

Improve the TPS importer#1385

Merged
veluca93 merged 4 commits into
cms-dev:mainfrom
veluca93:tps-improvements
Jun 8, 2025
Merged

Improve the TPS importer#1385
veluca93 merged 4 commits into
cms-dev:mainfrom
veluca93:tps-improvements

Conversation

@veluca93

@veluca93 veluca93 commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

Closes #1374

@veluca93 veluca93 force-pushed the tps-improvements branch from 311696f to 66d343a Compare June 8, 2025 07:39
@prandla

prandla commented Jun 8, 2025

Copy link
Copy Markdown
Member

these changes look fine to me, but i haven't used TPS, and there's no tests for it, so i'm not very confident in them.

Though, was deleting the symlinks in cmstestsuite/code intentional?

@veluca93 veluca93 force-pushed the tps-improvements branch from 66d343a to b7bb638 Compare June 8, 2025 16:51
@veluca93

veluca93 commented Jun 8, 2025

Copy link
Copy Markdown
Contributor Author

these changes look fine to me, but i haven't used TPS, and there's no tests for it, so i'm not very confident in them.

Though, was deleting the symlinks in cmstestsuite/code intentional?

Probably not. Reverted that.

I believe the changes were tested at past IOIs, so they should be fine...

@veluca93 veluca93 merged commit 2b159d5 into cms-dev:main Jun 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[IOI fork parity] TPS importer changes

5 participants