Round (sub)task scores to correct precision when displaying#1398
Merged
Conversation
Contributor
|
On the first two I agree. The third however is problematic, as it may make it impossible to get 100 points -- for example if for whatever reason someone decided to make 9 subtasks each worth 11.(1) points. IMO it should at the very least be in a different PR, and I am not sure we want it at all. |
prandla
force-pushed
the
score-rounding-2
branch
from
June 30, 2025 22:19
ad41d36 to
4367193
Compare
Member
Author
|
Undid some of the rounding; now scores are still computed as precise floats as far as possible and only rounded for display. I'll make a new issue to discuss rounding of subtasks further. |
Member
Author
|
actually, the scores in the ranking are still computed from rounded subtask scores (when using max over subtask scoring). fixing that requires more refactoring though; it's not a 2-line change. |
veluca93
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First two points are clearly bugs. The last point is a little more debatable; it would theoretically be possible to have higher precision for subtasks than for the whole task. But I feel like that could be confusing to contestants, and rarely useful.