Include dataset id in submission link#1657
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AWS admin submissions table so submission-detail links preserve the dataset context when multiple datasets exist, aligning with the already-supported /submission/<submission_id>/<dataset_id> URL shape.
Changes:
- Update the submission timestamp link in the submissions table macro to include
dataset.id.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
=======================================
Coverage 54.67% 54.67%
=======================================
Files 336 336
Lines 27448 27448
=======================================
Hits 15006 15006
Misses 12442 12442
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prandla
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1148
CMS already supports dataset-aware submission URLs in the form /submission/<submission_id>/<dataset_id>