Clarify GTR security questions to focus on Cloud Native Security Tenets#2027
Clarify GTR security questions to focus on Cloud Native Security Tenets#2027brandtkeller merged 1 commit intocncf:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR clarifies the General Technical Review (GTR) security questions so they explicitly reference the Cloud Native Security Tenets, and removes an ambiguous “cloud native principles” question.
Changes:
- Update the Cloud Native Security Tenets link to the current path under the TAG Security repository.
- Remove the redundant/ambiguous question about “cloud native principles,” keeping only the focused question on how projects satisfy the Cloud Native Security Tenets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@angellk @kevin-wangzefeng Could you please take a look? |
brandtkeller
left a comment
There was a problem hiding this comment.
Minor adjustment for accuracy
|
@brandtkeller, your suggestion has been accepted. Could you please give it another look and approval if no further comments? So we can move this forward then. |
|
I don't have any issue with accepting these changes - but I do want to acknowledge that this is updating the version under the '.archive' directory and not the actively linked version under 'toc_subprojects'. If that is the intent I can merge this as is. |
|
Thanks for pointing that out! When I originally submitted this PR, the actively linked version under toc_subprojects didn't exist yet — it was introduced after my PR was created. I've now checked the current version under toc_subprojects/project-reviews-subproject/general-technical-questions.md and found that the same issue exists there as well (the "Cloud Native Security Tenets" link, while currently resolving under the tag-security repo path, should be updated to point to the contribute-site repo to stay consistent with the ongoing migration). I think I can update this PR to apply the fix to both locations. What do you think? |
|
@RainbowMango that would be great if you don't mind. |
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com> Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
03e06cd to
55c2ec8
Compare
|
Done. |
This PR removes the redundant
cloud native principlesquestion from the Security section ofGeneral Technical Review questions. Based on PR #1441 discussions here, the question referencingcloud native principleswas intended to specifically address theCloud Native Security Tenets(the linked Cloud Native 8 document), not generic principles.Fixes #1673