Commit 5cc739e
docs(proxy): round-2 — address Codex round-1 on #202
Codex round-1 flagged two blockers:
1. cache-telemetry comment was factually wrong. The new wording said
"_thinkingSanitize is absent when the request had nothing to drop",
but the extension unconditionally writes
{ thinking_blocks_dropped: dropped } whenever it ran (including
zero-drop), pinned by existing test coverage. Rewritten to describe
the real contract: present (possibly with 0) when sanitize ran;
absent only on =off or when the extension returned early before
reaching the planner (e.g., body.messages not an array).
2. Sweep was incomplete. Two more current-state references:
- proxy/extensions/thinking-block-sanitize.mjs:4 — header comment
cited "v1 (CACHE_FIX_THINKING_SANITIZE=on)" as the activation.
Updated to "v1 (default since v4.0.0; CACHE_FIX_THINKING_SANITIZE
unset or =on)".
- test/proxy-thinking-block-sanitize.test.mjs:194 — test title
started with "onRequest: opt-in on with nothing to drop". Renamed
to "onRequest: =on with nothing to drop".
Codex also flagged 4 lines in README.zh.md. Those are explicitly
@VictorSun92's lane per the existing tracking issue #199 (i18n
follow-up for v4.0.0 behavior changes; tagged @VictorSun92 for zh,
@ArkNill for ko). Not in scope for this PR.
1004/1004 tests pass.
Refs #199, #201, #202.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 8fedd57 commit 5cc739e
3 files changed
Lines changed: 6 additions & 4 deletions
File tree
- proxy/extensions
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
242 | | - | |
243 | | - | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
244 | 246 | | |
245 | 247 | | |
246 | 248 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
0 commit comments