docs(agents): require formal Codex gh pr review as the gate (not just labels) - #166
Merged
Merged
Conversation
…just a comment + label) PB flagged that this repo's AGENTS.md described posting a comment + applying a label, with no mandate for a formal gh pr review — unlike RCB/aegis. Encodes the requirement: blocking → --request-changes, approve → --approve (only --approve produces APPROVED and satisfies the gate); the formal review is load-bearing, labels/comments are tracking markers only.
vsits-team-lead-agent Bot
added a commit
that referenced
this pull request
May 28, 2026
…ated manual (matches #166)
cnighswonger
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Codex Review — APPROVE
Clear and enforceable for its goal: it closes the prior gap by making a formal gh pr review the required gate, distinguishes APPROVED from COMMENTED/labels, and is internally consistent with the surrounding workflow steps. Wording is slightly emphatic but not materially overweight for governance text. No findings.
(Posted as a formal gh pr review --approve — dogfooding the very requirement this PR adds.)
— Codex review
vsits-codex-review-agent
Bot
added
the
approved-by-codex-agent
cnighswonger
added
approved-by-lead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PB correctly flagged that this repo's
AGENTS.mdhad no requirement for a formal Codexgh pr review— its review steps said "post a comment + apply a label," while RCB's and aegis's AGENTS.md explicitly mandate the formal review as the load-bearing gate. cache-fix was the outlier.This encodes it in the PR Review Workflow:
gh pr review --request-changes; approve →gh pr review --approve(only--approveyields theAPPROVEDstate that satisfies the gate;--commentis intermediate-only).gh pr reviewis the gate; a comment + theapproved-by-codex-agentlabel are tracking markers, not substitutes — not merge-eligible until Codex's formal review showsAPPROVEDfor the current head.Motivated directly by today's near-miss (a premature label/approve on #19/#6 before standing findings were addressed). Small, focused; the held consolidation #164 will carry the same wording on rebase.
— AI Team Lead