Skip to content

Commit 39a2715

Browse files
elrrrrrrrclaude
andauthored
fix: playwright chromium should use playwright mirror, not chrome-for-testing (#71)
## 背景 #67 新增了 `PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST = https://cdn.npmmirror.com/binaries/chrome-for-testing`,用于适配 playwright 1.58 起 chromium 改走 CFT。当时演示通过,是因为 **playwright 1.58.0** 的 `cftUrl` 路径是 `{browserVersion}/{platform}/...`,恰好命中 npmmirror 的 chrome-for-testing 布局。 但这个指向随后失效,且误伤了老版本: | playwright | chromium 下载路径 | 需要的 host | |---|---|---| | ≤ 1.57.x | `builds/chromium/{rev}/chromium-mac-arm64.zip` | `binaries/playwright` | | 1.58.0 | `{browserVersion}/mac-arm64/chrome-mac-arm64.zip` | `binaries/chrome-for-testing` ← #67 只对这一版对 | | 1.58.1+ | `builds/cft/{browserVersion}/mac-arm64/chrome-mac-arm64.zip` | `binaries/playwright` | 两个问题: 1. **playwright 1.58.1** 把 CFT 路径从 `{version}/...` 改成了 `builds/cft/{version}/...`,`chrome-for-testing` 指向随之 404。 2. **≥1.52 的所有版本都读 `PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST`**(chromium 优先用它、再回退 `PLAYWRIGHT_DOWNLOAD_HOST`),所以该指向把 ≤1.57 也打挂了 —— `ut i` 装 playwright 1.57 直接 `NoSuchKey` 404。 ## 改动 删除 `PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST`,让 chromium 回退到 `PLAYWRIGHT_DOWNLOAD_HOST`(= `binaries/playwright`),与 firefox/webkit 一致。cnpmcore 的 `PlaywrightBinary` 无论老 `builds/chromium` 还是新 `builds/cft` 都发布在 `binaries/playwright` 下,故这是唯一对所有版本都成立的 host。 > 注:1.58+ 能真正下载还依赖 cnpmcore 把 `builds/cft/` 产物同步落盘(另有独立修复,见 cnpmcore 侧 PR)。本 PR 先修复 ≤1.57 的回归。 `npm test` 通过(8/8)。 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/cnpm/binary-mirror-config/71) <!-- Reviewable:end --> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 5afdc1c commit 39a2715

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
"PUPPETEER_CHROME_DOWNLOAD_BASE_URL": "https://cdn.npmmirror.com/binaries/chrome-for-testing",
5959
"PUPPETEER_CHROME_HEADLESS_SHELL_DOWNLOAD_BASE_URL": "https://cdn.npmmirror.com/binaries/chrome-for-testing",
6060
"PLAYWRIGHT_DOWNLOAD_HOST": "https://cdn.npmmirror.com/binaries/playwright",
61-
"PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST": "https://cdn.npmmirror.com/binaries/chrome-for-testing",
6261
"SENTRYCLI_CDNURL": "https://cdn.npmmirror.com/binaries/sentry-cli",
6362
"SAUCECTL_INSTALL_BINARY_MIRROR": "https://cdn.npmmirror.com/binaries/saucectl",
6463
"RE2_DOWNLOAD_MIRROR": "https://cdn.npmmirror.com/binaries/node-re2",

test/index.test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ describe('test/index.test.js', () => {
176176
SENTRYCLI_CDNURL: 'https://cdn.npmmirror.com/binaries/sentry-cli',
177177
SAUCECTL_INSTALL_BINARY_MIRROR: 'https://cdn.npmmirror.com/binaries/saucectl',
178178
PLAYWRIGHT_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/playwright',
179-
PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/chrome-for-testing',
180179
RE2_DOWNLOAD_MIRROR: 'https://cdn.npmmirror.com/binaries/node-re2',
181180
RE2_DOWNLOAD_SKIP_PATH: 'true',
182181
PRISMA_ENGINES_MIRROR: 'https://cdn.npmmirror.com/binaries/prisma',
@@ -248,7 +247,6 @@ describe('test/index.test.js', () => {
248247
ELECTRON_BUILDER_BINARIES_MIRROR: 'https://cdn.npmmirror.com/binaries/electron-builder-binaries/',
249248
SASS_BINARY_SITE: 'https://cdn.npmmirror.com/binaries/node-sass',
250249
PLAYWRIGHT_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/playwright',
251-
PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/chrome-for-testing',
252250
SWC_BINARY_SITE: 'https://cdn.npmmirror.com/binaries/node-swc',
253251
NWJS_URLBASE: 'https://cdn.npmmirror.com/binaries/nwjs/v',
254252
PUPPETEER_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/chrome-for-testing',
@@ -344,7 +342,6 @@ describe('test/index.test.js', () => {
344342
ELECTRON_BUILDER_BINARIES_MIRROR: 'https://cdn.npmmirror.com/binaries/electron-builder-binaries/',
345343
SASS_BINARY_SITE: 'https://cdn.npmmirror.com/binaries/node-sass',
346344
PLAYWRIGHT_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/playwright',
347-
PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/chrome-for-testing',
348345
SWC_BINARY_SITE: 'https://cdn.npmmirror.com/binaries/node-swc',
349346
NWJS_URLBASE: 'https://cdn.npmmirror.com/binaries/nwjs/v',
350347
PUPPETEER_DOWNLOAD_HOST: 'https://cdn.npmmirror.com/binaries/chrome-for-testing',

0 commit comments

Comments
 (0)