fix(playwright): sync from cdn.playwright.dev instead of deprecated azureedge#1099
Conversation
…zureedge `playwright.azureedge.net` is deprecated and returns HTTP 400 for the new `builds/cft/*` namespace that playwright 1.58.1+ uses for chromium. As a result the CFT chromium binaries never get mirrored and users on playwright >= 1.58 get 404 from `binaries/playwright/builds/cft/...`. `cdn.playwright.dev` serves both the legacy `builds/*` paths and the new `builds/cft/*` paths (verified 200 for driver / firefox / webkit / ffmpeg / old chromium / cft chromium), so it is a safe superset. Switch DOWNLOAD_HOST and update the test assertions accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
👮 Files not reviewed due to content moderation or server errors (2)
📝 Walkthrough
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the Playwright binary download host from the deprecated playwright.azureedge.net to cdn.playwright.dev in both the implementation and associated tests. This change resolves issues with the new builds/cft/* namespace returning 400 errors. I have no feedback to provide as the changes are correct and well-tested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR fixes Playwright binary mirroring for Playwright >= 1.58 by switching the upstream download host from the deprecated playwright.azureedge.net to cdn.playwright.dev, which serves both legacy builds/* artifacts and the newer builds/cft/* Chromium namespace required by modern Playwright releases.
Changes:
- Update
PlaywrightBinaryDOWNLOAD_HOSTtohttps://cdn.playwright.dev/(supports both legacy and CFT paths). - Update test assertions to expect
cdn.playwright.devURLs for CFT, driver, and legacy Chromium paths. - Refresh inline comments/examples to reflect the new host.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/common/adapter/binary/PlaywrightBinary.ts | Switches Playwright upstream download host to cdn.playwright.dev and updates related inline documentation. |
| test/common/adapter/binary/PlaywrightBinary.test.ts | Updates URL assertions to match the new download host across CFT + legacy paths. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 94.33% 94.22% -0.12%
==========================================
Files 211 213 +2
Lines 8684 8933 +249
Branches 1697 1765 +68
==========================================
+ Hits 8192 8417 +225
- Misses 492 516 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 4.34.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
问题
playwright >= 1.58 的 chromium 从镜像下载会 404:
binaries/playwright/builds/cft/{browserVersion}/...目录为空,从未被同步落盘。根因
PlaywrightBinary的上游DOWNLOAD_HOST用的是已废弃的playwright.azureedge.net。实测(跟随 307 重定向):builds/chromium/1200/...(老,≤1.57)builds/cft/145.0.7632.6/mac-arm64/...(新,1.58.1+)azureedge 只认老的
builds/*,不认 playwright 1.58.1 起启用的builds/cft/*新命名空间。所以同步 worker 抓 CFT 产物时拿到 400,chromium 二进制永远进不了镜像。补充确认:playwright 从 1.58 起不再发布老结构
builds/chromium/{rev}(cdn.playwright.dev/builds/chromium/1208也 404),1.58+ 的 chromium 只存在于 CFT 路径,没有旧目录可回退——所以必须把 CFT 同步跑通。改动
DOWNLOAD_HOST从https://playwright.azureedge.net/换成https://cdn.playwright.dev/,并同步更新测试断言。已验证 cdn.playwright.dev 对 driver / firefox / webkit / ffmpeg / 老 chromium / 新 cft chromium 全部 200,是 azureedge 的安全超集,不影响已有同步。
合并后需触发一次 playwright binary 重新同步,
builds/cft/产物才会落盘。🤖 Generated with Claude Code