Skip to content

Commit a6f4e9d

Browse files
coadometa-codesync[bot]
coado
authored and
meta-codesync[bot]
committed
Change parser config to accept regex in exclude symbols field. (facebook#56367)
Summary: Pull Request resolved: facebook#56367 Adds support for regex in the `exclude_symbols` field in the C++ API parser config. This enables better scoped definitions of symbols that should be matched. Changelog: [Internal] Reviewed By: huntie Differential Revision: D99844594
1 parent 8ac5c28 commit a6f4e9d

File tree

10 files changed

+114
-117
lines changed

10 files changed

+114
-117
lines changed

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,6 @@ class facebook::react::EventBeat {
21662166
public virtual void requestSynchronous() const;
21672167
public virtual ~EventBeat() = default;
21682168
public void setBeatCallback(facebook::react::EventBeat::BeatCallback beatCallback);
2169-
public void unstable_setInduceCallback(std::function<void()> callback);
21702169
}
21712170

21722171
struct facebook::react::EventBeat::OwnerBox {
@@ -2193,7 +2192,6 @@ class facebook::react::EventDispatcher {
21932192
public void dispatchEvent(facebook::react::RawEvent&& rawEvent) const;
21942193
public void dispatchStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode) const;
21952194
public void dispatchUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2196-
public void experimental_flushSync() const;
21972195
public void removeListener(const std::shared_ptr<const facebook::react::EventListener>& listener) const;
21982196
}
21992197

@@ -2219,8 +2217,6 @@ class facebook::react::EventEmitter {
22192217
public void dispatchUniqueEvent(std::string type, folly::dynamic&& payload, facebook::react::HighResTimeStamp eventTimestamp) const;
22202218
public void setEnabled(bool enabled);
22212219
public void setShadowNodeFamily(std::weak_ptr<const facebook::react::ShadowNodeFamily> shadowNodeFamily);
2222-
template <typename Lambda>
2223-
public void experimental_flushSync(Lambda syncFunc) const;
22242220
}
22252221

22262222
class facebook::react::EventEmitterWrapper : public jni::HybridClass<facebook::react::EventEmitterWrapper> {
@@ -2269,7 +2265,6 @@ class facebook::react::EventQueue {
22692265
public void enqueueEvent(facebook::react::RawEvent&& rawEvent) const;
22702266
public void enqueueStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode = facebook::react::EventQueue::UpdateMode::Asynchronous) const;
22712267
public void enqueueUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2272-
public void experimental_flushSync() const;
22732268
}
22742269

22752270
enum facebook::react::EventQueue::UpdateMode {
@@ -2823,7 +2818,6 @@ class facebook::react::JReactHostInspectorTarget : public jni::HybridClass<faceb
28232818
public virtual void captureScreenshot(const facebook::react::jsinspector_modern::HostTargetDelegate::PageCaptureScreenshotRequest&, const std::function<void(std::optional<std::string> base64Data)>& callback) override;
28242819
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) override;
28252820
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) override;
2826-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&) override;
28272821
public void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest& params, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener> executor) override;
28282822
public void recordFrameTimings(jni::alias_ref<JFrameTimingSequence::javaobject> frameTimingSequence);
28292823
public void sendDebuggerResumeCommand();
@@ -5179,7 +5173,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51795173
public std::shared_ptr<const facebook::react::ShadowNode> getNewestCloneOfShadowNode(const facebook::react::ShadowNode& shadowNode) const;
51805174
public std::shared_ptr<facebook::react::ShadowNode> cloneNode(const facebook::react::ShadowNode& shadowNode, const std::shared_ptr<const std::vector<std::shared_ptr<const facebook::react::ShadowNode>>>& children, facebook::react::RawProps rawProps) const;
51815175
public std::shared_ptr<facebook::react::ShadowNode> createNode(facebook::react::Tag tag, const std::string& componentName, facebook::react::SurfaceId surfaceId, facebook::react::RawProps props, facebook::react::InstanceHandle::Shared instanceHandle) const;
5182-
public std::weak_ptr<facebook::react::UIManagerAnimationBackend> unstable_getAnimationBackend();
51835176
public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTree::CommitOptions& commitOptions) const override;
51845177
public virtual void shadowTreeDidFinishReactCommit(const facebook::react::ShadowTree& shadowTree) const override;
51855178
public virtual void shadowTreeDidFinishTransaction(std::shared_ptr<const facebook::react::MountingCoordinator> mountingCoordinator, bool mountSynchronously) const override;
@@ -5208,7 +5201,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
52085201
public void synchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props);
52095202
public void unregisterCommitHook(facebook::react::UIManagerCommitHook& commitHook);
52105203
public void unregisterMountHook(facebook::react::UIManagerMountHook& mountHook);
5211-
public void unstable_setAnimationBackend(std::shared_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
52125204
public void updateShadowTree(std::unordered_map<facebook::react::Tag, folly::dynamic>&& tagToProps);
52135205
public void updateState(const facebook::react::StateUpdate& stateUpdate) const;
52145206
public void visitBinding(const std::function<void(const facebook::react::UIManager::UIManagerBinding& uiManagerBinding)>& callback, facebook::jsi::Runtime& runtime) const;
@@ -10392,7 +10384,6 @@ class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook:
1039210384
public virtual void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest&, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener>) override;
1039310385
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) = 0;
1039410386
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) = 0;
10395-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&);
1039610387
public virtual ~HostTargetDelegate() override;
1039710388
}
1039810389

@@ -10461,7 +10452,6 @@ class facebook::react::jsinspector_modern::ILocalConnection : public facebook::r
1046110452

1046210453
class facebook::react::jsinspector_modern::IPageStatusListener : public facebook::react::jsinspector_modern::IDestructible {
1046310454
public virtual void onPageRemoved(int);
10464-
public virtual void unstable_onHostTargetAdded();
1046510455
public virtual ~IPageStatusListener() = 0;
1046610456
}
1046710457

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2164,7 +2164,6 @@ class facebook::react::EventBeat {
21642164
public virtual void requestSynchronous() const;
21652165
public virtual ~EventBeat() = default;
21662166
public void setBeatCallback(facebook::react::EventBeat::BeatCallback beatCallback);
2167-
public void unstable_setInduceCallback(std::function<void()> callback);
21682167
}
21692168

21702169
struct facebook::react::EventBeat::OwnerBox {
@@ -2191,7 +2190,6 @@ class facebook::react::EventDispatcher {
21912190
public void dispatchEvent(facebook::react::RawEvent&& rawEvent) const;
21922191
public void dispatchStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode) const;
21932192
public void dispatchUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2194-
public void experimental_flushSync() const;
21952193
public void removeListener(const std::shared_ptr<const facebook::react::EventListener>& listener) const;
21962194
}
21972195

@@ -2217,8 +2215,6 @@ class facebook::react::EventEmitter {
22172215
public void dispatchUniqueEvent(std::string type, folly::dynamic&& payload, facebook::react::HighResTimeStamp eventTimestamp) const;
22182216
public void setEnabled(bool enabled);
22192217
public void setShadowNodeFamily(std::weak_ptr<const facebook::react::ShadowNodeFamily> shadowNodeFamily);
2220-
template <typename Lambda>
2221-
public void experimental_flushSync(Lambda syncFunc) const;
22222218
}
22232219

22242220
class facebook::react::EventEmitterWrapper : public jni::HybridClass<facebook::react::EventEmitterWrapper> {
@@ -2267,7 +2263,6 @@ class facebook::react::EventQueue {
22672263
public void enqueueEvent(facebook::react::RawEvent&& rawEvent) const;
22682264
public void enqueueStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode = facebook::react::EventQueue::UpdateMode::Asynchronous) const;
22692265
public void enqueueUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
2270-
public void experimental_flushSync() const;
22712266
}
22722267

22732268
enum facebook::react::EventQueue::UpdateMode {
@@ -2820,7 +2815,6 @@ class facebook::react::JReactHostInspectorTarget : public jni::HybridClass<faceb
28202815
public virtual void captureScreenshot(const facebook::react::jsinspector_modern::HostTargetDelegate::PageCaptureScreenshotRequest&, const std::function<void(std::optional<std::string> base64Data)>& callback) override;
28212816
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) override;
28222817
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) override;
2823-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&) override;
28242818
public void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest& params, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener> executor) override;
28252819
public void recordFrameTimings(jni::alias_ref<JFrameTimingSequence::javaobject> frameTimingSequence);
28262820
public void sendDebuggerResumeCommand();
@@ -5170,7 +5164,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51705164
public std::shared_ptr<const facebook::react::ShadowNode> getNewestCloneOfShadowNode(const facebook::react::ShadowNode& shadowNode) const;
51715165
public std::shared_ptr<facebook::react::ShadowNode> cloneNode(const facebook::react::ShadowNode& shadowNode, const std::shared_ptr<const std::vector<std::shared_ptr<const facebook::react::ShadowNode>>>& children, facebook::react::RawProps rawProps) const;
51725166
public std::shared_ptr<facebook::react::ShadowNode> createNode(facebook::react::Tag tag, const std::string& componentName, facebook::react::SurfaceId surfaceId, facebook::react::RawProps props, facebook::react::InstanceHandle::Shared instanceHandle) const;
5173-
public std::weak_ptr<facebook::react::UIManagerAnimationBackend> unstable_getAnimationBackend();
51745167
public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTree::CommitOptions& commitOptions) const override;
51755168
public virtual void shadowTreeDidFinishReactCommit(const facebook::react::ShadowTree& shadowTree) const override;
51765169
public virtual void shadowTreeDidFinishTransaction(std::shared_ptr<const facebook::react::MountingCoordinator> mountingCoordinator, bool mountSynchronously) const override;
@@ -5199,7 +5192,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
51995192
public void synchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props);
52005193
public void unregisterCommitHook(facebook::react::UIManagerCommitHook& commitHook);
52015194
public void unregisterMountHook(facebook::react::UIManagerMountHook& mountHook);
5202-
public void unstable_setAnimationBackend(std::shared_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
52035195
public void updateShadowTree(std::unordered_map<facebook::react::Tag, folly::dynamic>&& tagToProps);
52045196
public void updateState(const facebook::react::StateUpdate& stateUpdate) const;
52055197
public void visitBinding(const std::function<void(const facebook::react::UIManager::UIManagerBinding& uiManagerBinding)>& callback, facebook::jsi::Runtime& runtime) const;
@@ -10248,7 +10240,6 @@ class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook:
1024810240
public virtual void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest&, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener>) override;
1024910241
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) = 0;
1025010242
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) = 0;
10251-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&);
1025210243
public virtual ~HostTargetDelegate() override;
1025310244
}
1025410245

@@ -10317,7 +10308,6 @@ class facebook::react::jsinspector_modern::ILocalConnection : public facebook::r
1031710308

1031810309
class facebook::react::jsinspector_modern::IPageStatusListener : public facebook::react::jsinspector_modern::IDestructible {
1031910310
public virtual void onPageRemoved(int);
10320-
public virtual void unstable_onHostTargetAdded();
1032110311
public virtual ~IPageStatusListener() = 0;
1032210312
}
1032310313

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5051,7 +5051,6 @@ class facebook::react::EventBeat {
50515051
public virtual void requestSynchronous() const;
50525052
public virtual ~EventBeat() = default;
50535053
public void setBeatCallback(facebook::react::EventBeat::BeatCallback beatCallback);
5054-
public void unstable_setInduceCallback(std::function<void()> callback);
50555054
}
50565055

50575056
struct facebook::react::EventBeat::OwnerBox {
@@ -5066,7 +5065,6 @@ class facebook::react::EventDispatcher {
50665065
public void dispatchEvent(facebook::react::RawEvent&& rawEvent) const;
50675066
public void dispatchStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode) const;
50685067
public void dispatchUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
5069-
public void experimental_flushSync() const;
50705068
public void removeListener(const std::shared_ptr<const facebook::react::EventListener>& listener) const;
50715069
}
50725070

@@ -5092,8 +5090,6 @@ class facebook::react::EventEmitter {
50925090
public void dispatchUniqueEvent(std::string type, folly::dynamic&& payload, facebook::react::HighResTimeStamp eventTimestamp) const;
50935091
public void setEnabled(bool enabled);
50945092
public void setShadowNodeFamily(std::weak_ptr<const facebook::react::ShadowNodeFamily> shadowNodeFamily);
5095-
template <typename Lambda>
5096-
public void experimental_flushSync(Lambda syncFunc) const;
50975093
}
50985094

50995095
class facebook::react::EventListenerContainer {
@@ -5132,7 +5128,6 @@ class facebook::react::EventQueue {
51325128
public void enqueueEvent(facebook::react::RawEvent&& rawEvent) const;
51335129
public void enqueueStateUpdate(facebook::react::StateUpdate&& stateUpdate, facebook::react::EventQueue::UpdateMode updateMode = facebook::react::EventQueue::UpdateMode::Asynchronous) const;
51345130
public void enqueueUniqueEvent(facebook::react::RawEvent&& rawEvent) const;
5135-
public void experimental_flushSync() const;
51365131
}
51375132

51385133
enum facebook::react::EventQueue::UpdateMode {
@@ -5639,7 +5634,6 @@ struct facebook::react::JSModulesUnbundle::Module {
56395634
class facebook::react::JSRuntime {
56405635
public virtual facebook::jsi::Runtime& getRuntime() noexcept = 0;
56415636
public virtual facebook::react::jsinspector_modern::RuntimeTargetDelegate& getRuntimeTargetDelegate();
5642-
public virtual void unstable_initializeOnJsThread();
56435637
public virtual ~JSRuntime() = default;
56445638
}
56455639

@@ -7750,7 +7744,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
77507744
public std::shared_ptr<const facebook::react::ShadowNode> getNewestCloneOfShadowNode(const facebook::react::ShadowNode& shadowNode) const;
77517745
public std::shared_ptr<facebook::react::ShadowNode> cloneNode(const facebook::react::ShadowNode& shadowNode, const std::shared_ptr<const std::vector<std::shared_ptr<const facebook::react::ShadowNode>>>& children, facebook::react::RawProps rawProps) const;
77527746
public std::shared_ptr<facebook::react::ShadowNode> createNode(facebook::react::Tag tag, const std::string& componentName, facebook::react::SurfaceId surfaceId, facebook::react::RawProps props, facebook::react::InstanceHandle::Shared instanceHandle) const;
7753-
public std::weak_ptr<facebook::react::UIManagerAnimationBackend> unstable_getAnimationBackend();
77547747
public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTree::CommitOptions& commitOptions) const override;
77557748
public virtual void shadowTreeDidFinishReactCommit(const facebook::react::ShadowTree& shadowTree) const override;
77567749
public virtual void shadowTreeDidFinishTransaction(std::shared_ptr<const facebook::react::MountingCoordinator> mountingCoordinator, bool mountSynchronously) const override;
@@ -7779,7 +7772,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate {
77797772
public void synchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props);
77807773
public void unregisterCommitHook(facebook::react::UIManagerCommitHook& commitHook);
77817774
public void unregisterMountHook(facebook::react::UIManagerMountHook& mountHook);
7782-
public void unstable_setAnimationBackend(std::shared_ptr<facebook::react::UIManagerAnimationBackend> animationBackend);
77837775
public void updateShadowTree(std::unordered_map<facebook::react::Tag, folly::dynamic>&& tagToProps);
77847776
public void updateState(const facebook::react::StateUpdate& stateUpdate) const;
77857777
public void visitBinding(const std::function<void(const facebook::react::UIManager::UIManagerBinding& uiManagerBinding)>& callback, facebook::jsi::Runtime& runtime) const;
@@ -12681,7 +12673,6 @@ class facebook::react::jsinspector_modern::HostTargetDelegate : public facebook:
1268112673
public virtual void loadNetworkResource(const facebook::react::jsinspector_modern::LoadNetworkResourceRequest&, facebook::react::jsinspector_modern::ScopedExecutor<facebook::react::jsinspector_modern::NetworkRequestListener>) override;
1268212674
public virtual void onReload(const facebook::react::jsinspector_modern::HostTargetDelegate::PageReloadRequest& request) = 0;
1268312675
public virtual void onSetPausedInDebuggerMessage(const facebook::react::jsinspector_modern::HostTargetDelegate::OverlaySetPausedInDebuggerMessageRequest& request) = 0;
12684-
public virtual void unstable_onPerfIssueAdded(const facebook::react::jsinspector_modern::PerfIssuePayload&);
1268512676
public virtual ~HostTargetDelegate() override;
1268612677
}
1268712678

@@ -12750,7 +12741,6 @@ class facebook::react::jsinspector_modern::ILocalConnection : public facebook::r
1275012741

1275112742
class facebook::react::jsinspector_modern::IPageStatusListener : public facebook::react::jsinspector_modern::IDestructible {
1275212743
public virtual void onPageRemoved(int);
12753-
public virtual void unstable_onHostTargetAdded();
1275412744
public virtual ~IPageStatusListener() = 0;
1275512745
}
1275612746

@@ -15786,7 +15776,6 @@ struct JS::NativeImageEditor::OptionsSize {
1578615776
struct JS::NativeNetworkingIOS::SpecSendRequestQuery {
1578715777
protected NSString* method() const;
1578815778
protected NSString* responseType() const;
15789-
protected NSString* unstable_devToolsRequestId() const;
1579015779
protected NSString* url() const;
1579115780
protected SpecSendRequestQuery(NSDictionary* const v);
1579215781
protected bool incrementalUpdates() const;

0 commit comments

Comments
 (0)