Skip to content

Commit aeedaa5

Browse files
coadometa-codesync[bot]
coado
authored and
meta-codesync[bot]
committed
Remove members that reference excluded symbols (facebook#56341)
Summary: Pull Request resolved: facebook#56341 Exclude members from .api snapshots when their types (return type, parameter types, variable type, typedef target, property type) reference excluded symbols. Previously, only compounds whose names matched exclude_symbols patterns were excluded — but members of non-excluded compounds could still reference excluded types, causing dangling type references (e.g., `facebook::yoga::ExperimentalFeature`) to appear in the snapshot. Changelog: [Internal] Differential Revision: D99434605
1 parent 6f329c1 commit aeedaa5

File tree

9 files changed

+351
-79
lines changed

9 files changed

+351
-79
lines changed

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3871,6 +3871,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
38713871
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
38723872
}
38733873

3874+
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
3875+
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
3876+
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
3877+
}
3878+
38743879
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
38753880
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
38763881
}
@@ -5657,6 +5662,7 @@ enum facebook::react::BlendMode {
56575662
Multiply,
56585663
Normal,
56595664
Overlay,
5665+
PlusLighter,
56605666
Saturation,
56615667
Screen,
56625668
SoftLight,
@@ -8920,6 +8926,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
89208926
public static constexpr std::string_view kModuleName;
89218927
}
89228928

8929+
template <typename T>
8930+
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
8931+
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
8932+
public static constexpr std::string_view kModuleName;
8933+
}
8934+
89238935
template <typename T>
89248936
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
89258937
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
@@ -10673,6 +10685,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
1067310685
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
1067410686
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
1067510687
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
10688+
public void notifyFastRefreshComplete();
1067610689
public ~RuntimeAgent();
1067710690
}
1067810691

@@ -12520,7 +12533,6 @@ const char* facebook::yoga::toString(facebook::yoga::Direction e);
1252012533
const char* facebook::yoga::toString(facebook::yoga::Display e);
1252112534
const char* facebook::yoga::toString(facebook::yoga::Edge e);
1252212535
const char* facebook::yoga::toString(facebook::yoga::Errata e);
12523-
const char* facebook::yoga::toString(facebook::yoga::ExperimentalFeature e);
1252412536
const char* facebook::yoga::toString(facebook::yoga::FlexDirection e);
1252512537
const char* facebook::yoga::toString(facebook::yoga::GridTrackType e);
1252612538
const char* facebook::yoga::toString(facebook::yoga::Gutter e);
@@ -12540,7 +12552,6 @@ constexpr YGDirection facebook::yoga::unscopedEnum(facebook::yoga::Direction sco
1254012552
constexpr YGDisplay facebook::yoga::unscopedEnum(facebook::yoga::Display scoped);
1254112553
constexpr YGEdge facebook::yoga::unscopedEnum(facebook::yoga::Edge scoped);
1254212554
constexpr YGErrata facebook::yoga::unscopedEnum(facebook::yoga::Errata scoped);
12543-
constexpr YGExperimentalFeature facebook::yoga::unscopedEnum(facebook::yoga::ExperimentalFeature scoped);
1254412555
constexpr YGFlexDirection facebook::yoga::unscopedEnum(facebook::yoga::FlexDirection scoped);
1254512556
constexpr YGGridTrackType facebook::yoga::unscopedEnum(facebook::yoga::GridTrackType scoped);
1254612557
constexpr YGGutter facebook::yoga::unscopedEnum(facebook::yoga::Gutter scoped);
@@ -12566,7 +12577,6 @@ constexpr facebook::yoga::Direction facebook::yoga::scopedEnum(YGDirection unsco
1256612577
constexpr facebook::yoga::Display facebook::yoga::scopedEnum(YGDisplay unscoped);
1256712578
constexpr facebook::yoga::Edge facebook::yoga::scopedEnum(YGEdge unscoped);
1256812579
constexpr facebook::yoga::Errata facebook::yoga::scopedEnum(YGErrata unscoped);
12569-
constexpr facebook::yoga::ExperimentalFeature facebook::yoga::scopedEnum(YGExperimentalFeature unscoped);
1257012580
constexpr facebook::yoga::FlexDirection facebook::yoga::scopedEnum(YGFlexDirection unscoped);
1257112581
constexpr facebook::yoga::FloatOptional facebook::yoga::maxOrDefined(facebook::yoga::FloatOptional lhs, facebook::yoga::FloatOptional rhs);
1257212582
constexpr facebook::yoga::GridTrackType facebook::yoga::scopedEnum(YGGridTrackType unscoped);
@@ -12653,10 +12663,8 @@ class facebook::yoga::Config : public YGConfig {
1265312663
public Config(YGLogger logger);
1265412664
public YGNodeRef cloneNode(YGNodeConstRef node, YGNodeConstRef owner, size_t childIndex) const;
1265512665
public bool hasErrata(facebook::yoga::Errata errata) const;
12656-
public bool isExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature) const;
1265712666
public bool useWebDefaults() const;
1265812667
public facebook::yoga::Errata getErrata() const;
12659-
public facebook::yoga::ExperimentalFeatureSet getEnabledExperiments() const;
1266012668
public float getPointScaleFactor() const;
1266112669
public static const facebook::yoga::Config& getDefault();
1266212670
public uint32_t getVersion() const noexcept;
@@ -12666,7 +12674,6 @@ class facebook::yoga::Config : public YGConfig {
1266612674
public void setCloneNodeCallback(YGCloneNodeFunc cloneNode);
1266712675
public void setContext(void* context);
1266812676
public void setErrata(facebook::yoga::Errata errata);
12669-
public void setExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature, bool enabled);
1267012677
public void setLogger(YGLogger logger);
1267112678
public void setPointScaleFactor(float pointScaleFactor);
1267212679
public void setUseWebDefaults(bool useWebDefaults);

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3868,6 +3868,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
38683868
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
38693869
}
38703870

3871+
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
3872+
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
3873+
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
3874+
}
3875+
38713876
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
38723877
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
38733878
}
@@ -5648,6 +5653,7 @@ enum facebook::react::BlendMode {
56485653
Multiply,
56495654
Normal,
56505655
Overlay,
5656+
PlusLighter,
56515657
Saturation,
56525658
Screen,
56535659
SoftLight,
@@ -8911,6 +8917,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
89118917
public static constexpr std::string_view kModuleName;
89128918
}
89138919

8920+
template <typename T>
8921+
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
8922+
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
8923+
public static constexpr std::string_view kModuleName;
8924+
}
8925+
89148926
template <typename T>
89158927
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
89168928
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
@@ -10529,6 +10541,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
1052910541
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
1053010542
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
1053110543
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
10544+
public void notifyFastRefreshComplete();
1053210545
public ~RuntimeAgent();
1053310546
}
1053410547

@@ -12376,7 +12389,6 @@ const char* facebook::yoga::toString(facebook::yoga::Direction e);
1237612389
const char* facebook::yoga::toString(facebook::yoga::Display e);
1237712390
const char* facebook::yoga::toString(facebook::yoga::Edge e);
1237812391
const char* facebook::yoga::toString(facebook::yoga::Errata e);
12379-
const char* facebook::yoga::toString(facebook::yoga::ExperimentalFeature e);
1238012392
const char* facebook::yoga::toString(facebook::yoga::FlexDirection e);
1238112393
const char* facebook::yoga::toString(facebook::yoga::GridTrackType e);
1238212394
const char* facebook::yoga::toString(facebook::yoga::Gutter e);
@@ -12396,7 +12408,6 @@ constexpr YGDirection facebook::yoga::unscopedEnum(facebook::yoga::Direction sco
1239612408
constexpr YGDisplay facebook::yoga::unscopedEnum(facebook::yoga::Display scoped);
1239712409
constexpr YGEdge facebook::yoga::unscopedEnum(facebook::yoga::Edge scoped);
1239812410
constexpr YGErrata facebook::yoga::unscopedEnum(facebook::yoga::Errata scoped);
12399-
constexpr YGExperimentalFeature facebook::yoga::unscopedEnum(facebook::yoga::ExperimentalFeature scoped);
1240012411
constexpr YGFlexDirection facebook::yoga::unscopedEnum(facebook::yoga::FlexDirection scoped);
1240112412
constexpr YGGridTrackType facebook::yoga::unscopedEnum(facebook::yoga::GridTrackType scoped);
1240212413
constexpr YGGutter facebook::yoga::unscopedEnum(facebook::yoga::Gutter scoped);
@@ -12422,7 +12433,6 @@ constexpr facebook::yoga::Direction facebook::yoga::scopedEnum(YGDirection unsco
1242212433
constexpr facebook::yoga::Display facebook::yoga::scopedEnum(YGDisplay unscoped);
1242312434
constexpr facebook::yoga::Edge facebook::yoga::scopedEnum(YGEdge unscoped);
1242412435
constexpr facebook::yoga::Errata facebook::yoga::scopedEnum(YGErrata unscoped);
12425-
constexpr facebook::yoga::ExperimentalFeature facebook::yoga::scopedEnum(YGExperimentalFeature unscoped);
1242612436
constexpr facebook::yoga::FlexDirection facebook::yoga::scopedEnum(YGFlexDirection unscoped);
1242712437
constexpr facebook::yoga::FloatOptional facebook::yoga::maxOrDefined(facebook::yoga::FloatOptional lhs, facebook::yoga::FloatOptional rhs);
1242812438
constexpr facebook::yoga::GridTrackType facebook::yoga::scopedEnum(YGGridTrackType unscoped);
@@ -12509,10 +12519,8 @@ class facebook::yoga::Config : public YGConfig {
1250912519
public Config(YGLogger logger);
1251012520
public YGNodeRef cloneNode(YGNodeConstRef node, YGNodeConstRef owner, size_t childIndex) const;
1251112521
public bool hasErrata(facebook::yoga::Errata errata) const;
12512-
public bool isExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature) const;
1251312522
public bool useWebDefaults() const;
1251412523
public facebook::yoga::Errata getErrata() const;
12515-
public facebook::yoga::ExperimentalFeatureSet getEnabledExperiments() const;
1251612524
public float getPointScaleFactor() const;
1251712525
public static const facebook::yoga::Config& getDefault();
1251812526
public uint32_t getVersion() const noexcept;
@@ -12522,7 +12530,6 @@ class facebook::yoga::Config : public YGConfig {
1252212530
public void setCloneNodeCallback(YGCloneNodeFunc cloneNode);
1252312531
public void setContext(void* context);
1252412532
public void setErrata(facebook::yoga::Errata errata);
12525-
public void setExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature, bool enabled);
1252612533
public void setLogger(YGLogger logger);
1252712534
public void setPointScaleFactor(float pointScaleFactor);
1252812535
public void setUseWebDefaults(bool useWebDefaults);

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4720,7 +4720,6 @@ class facebook::react::BaseTextInputProps : public facebook::react::HostPlatform
47204720
public facebook::react::SharedColor placeholderTextColor;
47214721
public facebook::react::SharedColor selectionColor;
47224722
public facebook::react::SharedColor selectionHandleColor;
4723-
public facebook::react::SharedColor underlineColorAndroid;
47244723
public facebook::react::SubmitBehavior getNonDefaultSubmitBehavior() const;
47254724
public facebook::react::SubmitBehavior submitBehavior;
47264725
public facebook::react::TextAttributes getEffectiveTextAttributes(facebook::react::Float fontSizeMultiplier) const;
@@ -6469,6 +6468,11 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
64696468
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
64706469
}
64716470

6471+
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
6472+
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
6473+
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
6474+
}
6475+
64726476
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
64736477
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
64746478
}
@@ -8262,6 +8266,7 @@ enum facebook::react::BlendMode {
82628266
Multiply,
82638267
Normal,
82648268
Overlay,
8269+
PlusLighter,
82658270
Saturation,
82668271
Screen,
82678272
SoftLight,
@@ -11295,6 +11300,12 @@ class facebook::react::NativeVibrationCxxSpec : public facebook::react::TurboMod
1129511300
public static constexpr std::string_view kModuleName;
1129611301
}
1129711302

11303+
template <typename T>
11304+
class facebook::react::NativeViewTransitionCxxSpec : public facebook::react::TurboModule {
11305+
protected NativeViewTransitionCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
11306+
public static constexpr std::string_view kModuleName;
11307+
}
11308+
1129811309
template <typename T>
1129911310
class facebook::react::NativeWebSocketModuleCxxSpec : public facebook::react::TurboModule {
1130011311
protected NativeWebSocketModuleCxxSpec(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
@@ -12964,6 +12975,7 @@ class facebook::react::jsinspector_modern::RuntimeAgent {
1296412975
public const facebook::react::jsinspector_modern::ExecutionContextDescription& getExecutionContextDescription() const;
1296512976
public facebook::react::jsinspector_modern::RuntimeAgent::ExportedState getExportedState();
1296612977
public void notifyBindingCalled(const std::string& bindingName, const std::string& payload);
12978+
public void notifyFastRefreshComplete();
1296712979
public ~RuntimeAgent();
1296812980
}
1296912981

@@ -14784,7 +14796,6 @@ const char* facebook::yoga::toString(facebook::yoga::Direction e);
1478414796
const char* facebook::yoga::toString(facebook::yoga::Display e);
1478514797
const char* facebook::yoga::toString(facebook::yoga::Edge e);
1478614798
const char* facebook::yoga::toString(facebook::yoga::Errata e);
14787-
const char* facebook::yoga::toString(facebook::yoga::ExperimentalFeature e);
1478814799
const char* facebook::yoga::toString(facebook::yoga::FlexDirection e);
1478914800
const char* facebook::yoga::toString(facebook::yoga::GridTrackType e);
1479014801
const char* facebook::yoga::toString(facebook::yoga::Gutter e);
@@ -14804,7 +14815,6 @@ constexpr YGDirection facebook::yoga::unscopedEnum(facebook::yoga::Direction sco
1480414815
constexpr YGDisplay facebook::yoga::unscopedEnum(facebook::yoga::Display scoped);
1480514816
constexpr YGEdge facebook::yoga::unscopedEnum(facebook::yoga::Edge scoped);
1480614817
constexpr YGErrata facebook::yoga::unscopedEnum(facebook::yoga::Errata scoped);
14807-
constexpr YGExperimentalFeature facebook::yoga::unscopedEnum(facebook::yoga::ExperimentalFeature scoped);
1480814818
constexpr YGFlexDirection facebook::yoga::unscopedEnum(facebook::yoga::FlexDirection scoped);
1480914819
constexpr YGGridTrackType facebook::yoga::unscopedEnum(facebook::yoga::GridTrackType scoped);
1481014820
constexpr YGGutter facebook::yoga::unscopedEnum(facebook::yoga::Gutter scoped);
@@ -14830,7 +14840,6 @@ constexpr facebook::yoga::Direction facebook::yoga::scopedEnum(YGDirection unsco
1483014840
constexpr facebook::yoga::Display facebook::yoga::scopedEnum(YGDisplay unscoped);
1483114841
constexpr facebook::yoga::Edge facebook::yoga::scopedEnum(YGEdge unscoped);
1483214842
constexpr facebook::yoga::Errata facebook::yoga::scopedEnum(YGErrata unscoped);
14833-
constexpr facebook::yoga::ExperimentalFeature facebook::yoga::scopedEnum(YGExperimentalFeature unscoped);
1483414843
constexpr facebook::yoga::FlexDirection facebook::yoga::scopedEnum(YGFlexDirection unscoped);
1483514844
constexpr facebook::yoga::FloatOptional facebook::yoga::maxOrDefined(facebook::yoga::FloatOptional lhs, facebook::yoga::FloatOptional rhs);
1483614845
constexpr facebook::yoga::GridTrackType facebook::yoga::scopedEnum(YGGridTrackType unscoped);
@@ -14917,10 +14926,8 @@ class facebook::yoga::Config : public YGConfig {
1491714926
public Config(YGLogger logger);
1491814927
public YGNodeRef cloneNode(YGNodeConstRef node, YGNodeConstRef owner, size_t childIndex) const;
1491914928
public bool hasErrata(facebook::yoga::Errata errata) const;
14920-
public bool isExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature) const;
1492114929
public bool useWebDefaults() const;
1492214930
public facebook::yoga::Errata getErrata() const;
14923-
public facebook::yoga::ExperimentalFeatureSet getEnabledExperiments() const;
1492414931
public float getPointScaleFactor() const;
1492514932
public static const facebook::yoga::Config& getDefault();
1492614933
public uint32_t getVersion() const noexcept;
@@ -14930,7 +14937,6 @@ class facebook::yoga::Config : public YGConfig {
1493014937
public void setCloneNodeCallback(YGCloneNodeFunc cloneNode);
1493114938
public void setContext(void* context);
1493214939
public void setErrata(facebook::yoga::Errata errata);
14933-
public void setExperimentalFeatureEnabled(facebook::yoga::ExperimentalFeature feature, bool enabled);
1493414940
public void setLogger(YGLogger logger);
1493514941
public void setPointScaleFactor(float pointScaleFactor);
1493614942
public void setUseWebDefaults(bool useWebDefaults);
@@ -15729,8 +15735,6 @@ struct JS::NativeDeviceInfo::DimensionsPayload::Builder {
1572915735
struct JS::NativeDeviceInfo::DimensionsPayload::Builder::Input {
1573015736
protected std::optional<JS::NativeDeviceInfo::DisplayMetrics::Builder> screen;
1573115737
protected std::optional<JS::NativeDeviceInfo::DisplayMetrics::Builder> window;
15732-
protected std::optional<JS::NativeDeviceInfo::DisplayMetricsAndroid::Builder> screenPhysicalPixels;
15733-
protected std::optional<JS::NativeDeviceInfo::DisplayMetricsAndroid::Builder> windowPhysicalPixels;
1573415738
}
1573515739

1573615740
struct JS::NativeDeviceInfo::DisplayMetrics {

0 commit comments

Comments
 (0)